Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: craftworkco/prefixed_ids
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: excid3/prefixed_ids
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 12 files changed
  • 4 contributors

Commits on Nov 14, 2024

  1. Update README (excid3#83)

    @cjavdev
    cjavdev authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5c51967 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Ensure prefixes are unique (excid3#86) 

    When two or more models are defined with the same prefix, `PrefixedIds.find` will load the model for whichever one was defined last, and could lead to loading an unexpected model for a given prefixed id.

For apps with lots of models it’s quite easy to add the same prefix on two or more models by mistake. It’s also not obvious how to access or list the prefixes already in use, so I think it makes sense for the gem to protect against this.

This PR adds a check when calling `has_prefix_id` and raises `PrefixedIds::Error` if the same prefix was already defined for a different model.
    @samoli
    samoli authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9e391c1 View commit details
    Browse the repository at this point in the history

  2. Update appraisals

    @excid3
    excid3 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5fb4d4a View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Bump rails-html-sanitizer from 1.6.0 to 1.6.1 (excid3#88) 

    Bumps [rails-html-sanitizer](https://github.com/rails/rails-html-sanitizer) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/rails/rails-html-sanitizer/releases)
- [Changelog](https://github.com/rails/rails-html-sanitizer/blob/main/CHANGELOG.md)
- [Commits](rails/rails-html-sanitizer@v1.6.0...v1.6.1)

---
updated-dependencies:
- dependency-name: rails-html-sanitizer
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    b861a04 View commit details
    Browse the repository at this point in the history
Loading