Skip to content

feat: Add sqlite offline store #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat: Add sqlite offline store #5319

wants to merge 7 commits into from

Conversation

franciscojavierarceo
Copy link
Member

@franciscojavierarceo franciscojavierarceo commented May 2, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Borked #5298

devin-ai-integration bot and others added 2 commits May 2, 2025 12:36
@devin-ai-integration @franciscojavierarceo
Add SQLite offline store implementation
0991630 
Co-Authored-By: Francisco Javier Arceo <[email protected]>
@devin-ai-integration @franciscojavierarceo
Apply linting fixes to SQLite offline store
c855215 
Co-Authored-By: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo franciscojavierarceo changed the title Devin/1745638554 sqlite offline store feat: Add sqlite offline store May 2, 2025
franciscojavierarceo and others added 5 commits May 2, 2025 13:53
@franciscojavierarceo
adding sqlite to operator validation
9dba260 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fixed linter
0976a9c 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
removing release file
abf4dcb 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@devin-ai-integration @franciscojavierarceo
test: Add unit tests for SQLite offline store
1e93d14 
Co-Authored-By: Francisco Javier Arceo <[email protected]>
@devin-ai-integration @franciscojavierarceo
style: Apply formatting to SQLite offline store tests
1af7c70 
Co-Authored-By: Francisco Javier Arceo <[email protected]>
tchughesiv
tchughesiv requested changes May 4, 2025
View reviewed changes
Copy link
Contributor

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add here as well -

feast/infra/feast-operator/api/v1alpha1/featurestore_types.go

Line 303 in 1af7c70

// +kubebuilder:validation:Enum=file;dask;duckdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchughesiv tchughesiv tchughesiv requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscojavierarceo @tchughesiv