Skip to content

build: tool.setuptools.namespaces = false #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yxtay
Copy link

@yxtay yxtay commented May 5, 2025

What this PR does / why we need it:

https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#custom-discovery
https://github.com/feast-dev/feast/blob/master/setup.py

Based on the documentation and following the setup.py that was based on, the namespace = false should be set in [tool.setuptools]

  • In setup.py, find_packages was used instead of find_namespace_packages
  • This will ensure that the docs and requirements folder are not errorneously included in the feast package
  • Part of the reason why I want this is that the requirements.txt files in the requirements folder is being flagged out to contain vulnerable versions in container scans
    • This causes false positives in vulnerability notifications
  • I'm also facing issues with vulnerabilities being flagged out due to versions in the package.json in the sdk/python/ui/package.json and the Dockerfiles in sdk/python/feast/infra/feature_servers/multicloud, but do not have any suggestions yet.
    • My sense is that sdk/python/ui should not be included in the python package, but I'm not sure what exactly is it's purpose and who uses it right now

Which issue(s) this PR fixes:

Misc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant