fix: Fix pandas 2.x compatibility issue of Trino offline store caused by removed Series.iteritems() method #5345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Trino offline store connector
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| [](https://pypi.org/project/feast/) | |||
| [](https://github.com/feast-dev/feast/graphs/contributors) | |||
| [](https://github.com/feast-dev/feast/actions/workflows/unit_tests.yml) | |||
| [](https://github.com/feast-dev/feast/actions/workflows/unit_tests.yml) | |||
There was a problem hiding this comment.
Was this from the linter?
There was a problem hiding this comment.
Yep, that's from commit hooks, I only changed upload.py file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an
AttributeErrorencountered when usingfeast.get_historical_features()with Trino as offline store andpandas>=2.0.0, whereSeries.iteritems()has been removed. The code now usesrow.items(), which is compatible with both older and newer pandas versions.What this PR does / why we need it:
Feast with Trino as offline store currently breaks when used with pandas 2.x due to the removal of
Series.iteritems(). This simple change ensures compatibility with modern pandas versions while retaining backwards compatibility with <2.0.0.So users don't have to add
pandas>=1.5.3,<2.0.0torequirements.txt, this PR will replace iteritems() method with items() for pandas 2.x compatibility in Trino offline store connector.Which issue(s) this PR fixes:
N/A — this issue was found independently and not yet tracked.
Misc
This PR ensures compatibility with
pandas >= 0.23.0when calling historical feature retrieval function with Trino offline store.Realese note: Fix pandas 2.x compatibility issue of Trino offline store caused by removed Series.iteritems() method