Add support for extend type to parser

Author: cjoudrey

lib/graphql/compatibility/schema_parser_specification.rb

@@ -263,6 +263,109 @@ def test_it_parses_scalar_extensions
             assert_equal 'somethingElse', scalar_extension.directives.last.name
           end
 
+          def test_it_parses_object_type_extensions_with_field_definitions
+            document = parse('
+              extend type User {
+                login: String!
+              }
+            ')
+
+            object_type_extension = document.definitions.first
+            assert_equal GraphQL::Language::Nodes::ObjectTypeExtension, object_type_extension.class
+            assert_equal 'User', object_type_extension.name
+            assert_equal [2, 15], object_type_extension.position
+
+            assert_equal 1, object_type_extension.fields.length
+            assert_equal GraphQL::Language::Nodes::FieldDefinition, object_type_extension.fields.first.class
+          end
+
+          def test_it_parses_object_type_extensions_with_field_definitions_and_directives
+            document = parse('
+              extend type User @deprecated {
+                login: String!
+              }
+            ')
+
+            object_type_extension = document.definitions.first
+            assert_equal GraphQL::Language::Nodes::ObjectTypeExtension, object_type_extension.class
+            assert_equal 'User', object_type_extension.name
+            assert_equal [2, 15], object_type_extension.position
+
+            assert_equal 1, object_type_extension.fields.length
+            assert_equal GraphQL::Language::Nodes::FieldDefinition, object_type_extension.fields.first.class
+
+            assert_equal 1, object_type_extension.directives.length
+            assert_equal GraphQL::Language::Nodes::Directive, object_type_extension.directives.first.class
+          end
+
+          def test_it_parses_object_type_extensions_with_field_definitions_and_implements
+            document = parse('
+              extend type User implements Node {
+                login: String!
+              }
+            ')
+
+            object_type_extension = document.definitions.first
+            assert_equal GraphQL::Language::Nodes::ObjectTypeExtension, object_type_extension.class
+            assert_equal 'User', object_type_extension.name
+            assert_equal [2, 15], object_type_extension.position
+
+            assert_equal 1, object_type_extension.fields.length
+            assert_equal GraphQL::Language::Nodes::FieldDefinition, object_type_extension.fields.first.class
+
+            assert_equal 1, object_type_extension.interfaces.length
+            assert_equal GraphQL::Language::Nodes::TypeName, object_type_extension.interfaces.first.class
+          end
+
+          def test_it_parses_object_type_extensions_with_only_directives
+            document = parse('
+              extend type User @deprecated
+            ')
+
+            object_type_extension = document.definitions.first
+            assert_equal GraphQL::Language::Nodes::ObjectTypeExtension, object_type_extension.class
+            assert_equal 'User', object_type_extension.name
+            assert_equal [2, 15], object_type_extension.position
+
+            assert_equal 1, object_type_extension.directives.length
+            assert_equal GraphQL::Language::Nodes::Directive, object_type_extension.directives.first.class
+            assert_equal 'deprecated', object_type_extension.directives.first.name
+          end
+
+          def test_it_parses_object_type_extensions_with_implements_and_directives
+            document = parse('
+              extend type User implements Node @deprecated
+            ')
+
+            object_type_extension = document.definitions.first
+            assert_equal GraphQL::Language::Nodes::ObjectTypeExtension, object_type_extension.class
+            assert_equal 'User', object_type_extension.name
+            assert_equal [2, 15], object_type_extension.position
+
+            assert_equal 1, object_type_extension.directives.length
+            assert_equal GraphQL::Language::Nodes::Directive, object_type_extension.directives.first.class
+            assert_equal 'deprecated', object_type_extension.directives.first.name
+
+            assert_equal 1, object_type_extension.interfaces.length
+            assert_equal GraphQL::Language::Nodes::TypeName, object_type_extension.interfaces.first.class
+            assert_equal 'Node', object_type_extension.interfaces.first.name
+          end
+
+          def test_it_parses_object_type_extensions_with_only_implements
+            document = parse('
+              extend type User implements Node
+            ')
+
+            object_type_extension = document.definitions.first
+            assert_equal GraphQL::Language::Nodes::ObjectTypeExtension, object_type_extension.class
+            assert_equal 'User', object_type_extension.name
+            assert_equal [2, 15], object_type_extension.position
+
+            assert_equal 1, object_type_extension.interfaces.length
+            assert_equal GraphQL::Language::Nodes::TypeName, object_type_extension.interfaces.first.class
+            assert_equal 'Node', object_type_extension.interfaces.first.name
+          end
+
           def test_it_parses_whole_definition_with_descriptions
             document = parse(SCHEMA_DEFINITION_STRING)
 

lib/graphql/language/nodes.rb

@@ -446,6 +446,8 @@ def children
         end
       end
 
+      class ObjectTypeExtension < ObjectTypeDefinition; end;
+
       class InputValueDefinition < AbstractNode
         attr_accessor :name, :type, :default_value, :directives,:description
         alias :children :directives

lib/graphql/language/parser.y

@@ -307,9 +307,17 @@ rule
 
   type_extension:
       scalar_type_extension
+    | object_type_extension
 
   scalar_type_extension: EXTEND SCALAR name directives_list { return make_node(:ScalarTypeExtension, name: val[2], directives: val[3], position_source: val[0]) }
 
+  object_type_extension:
+      /* TODO - This first one shouldn't be necessary but parser is getting confused */
+      EXTEND TYPE name implements LCURLY field_definition_list RCURLY { return make_node(:ObjectTypeExtension, name: val[2], interfaces: val[3], directives: [], fields: val[5], position_source: val[0]) }
+    | EXTEND TYPE name implements_opt directives_list_opt LCURLY field_definition_list RCURLY { return make_node(:ObjectTypeExtension, name: val[2], interfaces: val[3], directives: val[4], fields: val[6], position_source: val[0]) }
+    | EXTEND TYPE name implements_opt directives_list { return make_node(:ObjectTypeExtension, name: val[2], interfaces: val[3], directives: val[4], fields: [], position_source: val[0]) }
+    | EXTEND TYPE name implements { return make_node(:ObjectTypeExtension, name: val[2], interfaces: val[3], directives: [], fields: [], position_source: val[0]) }
+
   scalar_type_definition: SCALAR name directives_list_opt { return make_node(:ScalarTypeDefinition, name: val[1], directives: val[2], description: get_description(val[0]), position_source: val[0]) }
 
   object_type_definition:
@@ -319,7 +327,10 @@ rule
 
   implements_opt:
       /* none */ { return [] }
-    | IMPLEMENTS AMP interfaces_list { return val[2] }
+    | implements
+
+  implements:
+      IMPLEMENTS AMP interfaces_list { return val[2] }
     | IMPLEMENTS interfaces_list { return val[1] }
     | IMPLEMENTS legacy_interfaces_list { return val[1] }