Skip to content

Commit d31f158

Browse files
committed
Add feature flip for pull requests.
1 parent dd33867 commit d31f158

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

lib/travis/github/payload/pull_request.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ def event
1515
end
1616

1717
def accept?
18+
return false if pull_requests_disabled?
1819
case action
1920
when :opened, :reopened then !!merge_commit
2021
when :synchronize then head_change?
@@ -91,6 +92,10 @@ def merge_commit
9192
pull_request['merge_commit']
9293
end
9394

95+
def pull_requests_disabled?
96+
Travis::Features.feature_deactivated?(:pull_requests)
97+
end
98+
9499
private
95100

96101
def repo

spec/travis/github/payload/pull_request_spec.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44
let(:payload) { Travis::Github::Payload.for('pull_request', GITHUB_PAYLOADS['pull-request']) }
55

66
describe 'accept' do
7+
before do
8+
Travis::Features.start
9+
Travis::Features.enable_for_all(:pull_requests)
10+
end
11+
712
describe 'given action is "opened"' do
813
before :each do
914
payload.event.data['action'] = 'opened'
@@ -17,6 +22,11 @@
1722
payload.event.data['pull_request']['merge_commit'] = nil
1823
payload.should_not be_accept
1924
end
25+
26+
it "rejects when the feature is disabled" do
27+
Travis::Features.disable_for_all(:pull_requests)
28+
payload.accept?.should be_false
29+
end
2030
end
2131

2232
describe 'given action is "reopened"' do

0 commit comments

Comments
 (0)