正确支持 User login 里面的大小写字母，不再全部转成小写。

之前转小写是错误的配置了 Devise 的 case_insensitive_keys
修正某些字符的用户名主页无法打开的问题;

Author: huacnlee

app/controllers/users_controller.rb

@@ -35,13 +35,13 @@ def show
   protected
 
   def set_user
-    # 处理 login 有大写字母的情况
-    if params[:id] != params[:id].downcase
-      redirect_to request.path.downcase, status: 301
-      return
+    @user = User.find_login!(params[:id])
+
+    # 转向正确的拼写
+    if @user.login != params[:id]
+      redirect_to user_path(@user.login), status: 301
     end
 
-    @user = User.find_login!(params[:id])
     @user_type = @user.user_type
     if @user.deleted?
       render_404

app/models/user.rb

@@ -212,13 +212,12 @@ def self.find_login!(slug)
 
   def self.find_login(slug)
     return nil unless slug =~ ALLOW_LOGIN_CHARS_REGEXP
-    slug = slug.downcase
-    fetch_by_uniq_keys(login: slug)
+    fetch_by_uniq_keys(login: slug) || where("lower(login) = ?", slug.downcase).take
   end
 
   def self.find_by_login_or_email(login_or_email)
     login_or_email = login_or_email.downcase
-    fetch_by_uniq_keys(login: login_or_email) || fetch_by_uniq_keys(email: login_or_email)
+    find_login(login_or_email) || find_by_email(login_or_email)
   end
 
   def self.find_for_database_authentication(warden_conditions)

config/initializers/devise.rb

@@ -28,7 +28,7 @@
   # Configure which authentication keys should be case-insensitive.
   # These keys will be downcased upon creating or modifying a user and when used
   # to authenticate or find a user. Default is :email.
-  config.case_insensitive_keys = [:email, :login]
+  config.case_insensitive_keys = [:email]
 
   # Configure which authentication keys should have whitespace stripped.
   # These keys will have whitespace before and after removed upon creating or

config/routes.rb

@@ -186,7 +186,7 @@
   get 'users/city/:id' => 'users#city', as: 'location_users'
   get 'users' => 'users#index', as: 'users'
 
-  constraints(id: /[\w\-\.]*/) do
+  constraints(id: /[a-zA-Z0-9\_\-\.]*/) do
     resources :users, path: '', as: 'users' do
       member do
         # User only

spec/controllers/users_controller_spec.rb

@@ -34,6 +34,11 @@
       get :topics, params: { id: user.login }
       expect(response).to be_success
     end
+
+    it 'should redirect to right spell login' do
+      get :topics, params: { id: user.login.upcase }
+      expect(response.status).to eq(301)
+    end
   end
 
   describe ':replies' do

spec/models/user_spec.rb

@@ -66,6 +66,17 @@
       let(:user) { build(:user, login: 'aaa*11') }
       it { expect(user.valid?).to eq false }
     end
+
+    describe 'Login allow upcase downcase both' do
+      let(:user1) { create(:user, login: 'ReiIs123') }
+
+      it 'should work' do
+        expect(user1.login).to eq('ReiIs123')
+        expect(User.find_login('ReiIs123').id).to eq(user1.id)
+        expect(User.find_login('reiis123').id).to eq(user1.id)
+        expect(User.find_login('rEIIs123').id).to eq(user1.id)
+      end
+    end
   end
 
   describe '#read_topic?' do