Fix bug in doc delay

Author: jamesls

awsshell/app.py

@@ -5,6 +5,7 @@
 """
 import tempfile
 import subprocess
+import logging
 
 from prompt_toolkit.document import Document
 from prompt_toolkit.shortcuts import create_eventloop
@@ -18,6 +19,9 @@
 from awsshell.ui import create_default_layout
 
 
+LOG = logging.getLogger(__name__)
+
+
 def create_aws_shell(completer, history, docs):
     return AWSShell(completer, history, docs)
 
@@ -103,13 +107,9 @@ def on_input_timeout(self, cli):
         buffer = cli.current_buffer
         document = buffer.document
         text = document.text
+        LOG.debug("document.text = %s", text)
+        LOG.debug("current_command = %s", self.completer.current_command)
         if text.strip():
-            # TODO: Big todo here.  Relying on the completer
-            # command means we're always "a step behind."
-            # We don't pull up docs until you start typing
-            # the next component :(
-            # We need to hook into prompt_toolkits auto
-            # completion event.
             command = self.completer.current_command
             key_name = '.'.join(command.split()).encode('utf-8')
             last_option = self.completer.last_option
@@ -122,6 +122,7 @@ def on_input_timeout(self, cli):
             self.current_docs = u''
         cli.buffers['clidocs'].reset(
             initial_document=Document(self.current_docs, cursor_position=0))
+        cli.request_redraw()
 
     def create_cli_interface(self):
         # A CommandLineInterface from prompt_toolkit

tests/test_completions.py

@@ -252,3 +252,34 @@ def test_can_handle_skips_in_completion(index_data):
     c = completer.autocomplete
     result = c('ec2 create-ta')
     assert result == ['create-tags']
+
+
+def test_cmd_path_updated_on_completions(index_data):
+    index_data['aws']['commands'] = ['ec2']
+    index_data['aws']['children'] = {
+        'ec2': {
+            'commands': ['create-tags', 'describe-instances'],
+            'argument_metadata': {},
+            'arguments': [],
+            'children': {
+                'create-tags': {
+                    'commands': [],
+                    'argument_metadata': {
+                        '--resources': {'example': '', 'minidoc': 'foo'},
+                        '--tags': {'example': 'bar', 'minidoc': 'baz'},
+                    },
+                    'arguments': ['--resources', '--tags'],
+                }
+            }
+        }
+    }
+    completer = AWSCLIModelCompleter(index_data)
+    c = completer.autocomplete
+    result = c('ec2 create-tags ')
+    assert result == []
+    assert completer.cmd_path == ['aws', 'ec2', 'create-tags']
+    assert completer.arg_metadata == {
+        '--resources': {'example': '', 'minidoc': 'foo'},
+        '--tags': {'example': 'bar', 'minidoc': 'baz'},
+    }
+