Fixing build warnings (dotnet#21044)

Author: BrennanConroy

NuGet.config

@@ -11,5 +11,7 @@
     <add key="aspnetcore-dev" value="https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json" />
     <add key="aspnetcore-tools" value="https://dotnet.myget.org/F/aspnetcore-tools/api/v3/index.json" />
     <add key="roslyn-tools" value="https://dotnet.myget.org/F/roslyn-tools/api/v3/index.json" />
+    <!-- Used for the SiteExtension 3.1 bits that are included in the 5.0 build -->
+    <add key="dotnet31-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet3.1-transport/nuget/v3/index.json" />
   </packageSources>
 </configuration>

src/Servers/IIS/IIS/benchmarks/IIS.Performance/FirstRequestConfig.cs

@@ -18,22 +18,22 @@ internal class FirstRequestConfig : ManualConfig
     {
         public FirstRequestConfig()
         {
-            Add(ConsoleLogger.Default);
-            Add(MarkdownExporter.GitHub);
+            AddLogger(ConsoleLogger.Default);
+            AddExporter(MarkdownExporter.GitHub);
 
-            Add(MemoryDiagnoser.Default);
-            Add(StatisticColumn.OperationsPerSecond);
-            Add(DefaultColumnProviders.Instance);
+            AddDiagnoser(MemoryDiagnoser.Default);
+            AddColumn(StatisticColumn.OperationsPerSecond);
+            AddColumnProvider(DefaultColumnProviders.Instance);
 
-            Add(JitOptimizationsValidator.FailOnError);
+            AddValidator(JitOptimizationsValidator.FailOnError);
 
-            Add(Job.Default
-                .With(CsProjCoreToolchain.From(NetCoreAppSettings.NetCoreApp21))
-                .With(new GcMode { Server = true })
+            AddJob(Job.Default
+                .WithToolchain(CsProjCoreToolchain.From(NetCoreAppSettings.NetCoreApp21))
+                .WithGcMode(new GcMode { Server = true })
                 .WithIterationCount(10)
                 .WithInvocationCount(1)
                 .WithUnrollFactor(1)
-                .With(RunStrategy.ColdStart));
+                .WithStrategy(RunStrategy.ColdStart));
         }
     }
 }

src/SiteExtensions/LoggingBranch/Directory.Build.targets

@@ -22,4 +22,7 @@
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
   </PropertyGroup>
 
+  <!-- No code in this project to compile. -->
+  <Target Name="Compile" />
+
 </Project>

src/SiteExtensions/LoggingBranch/LB.csproj

@@ -31,9 +31,6 @@
     </ProjectReference>
   </ItemGroup>
 
-  <!-- No code in this project to compile. -->
-  <Target Name="Compile" />
-
   <!-- Cannot assume this project and Microsoft.AspNetCore.AzureAppServices.HostingStartup have the same package version. -->
   <Target Name="_GetHostingStartupPackageReference" BeforeTargets="GenerateHostingStartupDeps">
     <!-- This target is defined in eng/targets/Packaging.targets and included in every C# and F# project. -->