Skip to content

Commit 0ac877c

Browse files
authored
Merge pull request cloudbees-oss#416 from cloudbees-oss/fix-APIRateLimitExceeded
Configure the polling interval/delay to be less aggressive in ITs
2 parents ddd9f3c + ebb6aa4 commit 0ac877c

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/test/java/org/zendesk/client/v2/RealSmokeTest.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.zendesk.client.v2;
22

33
import org.apache.commons.lang3.time.DateUtils;
4+
import org.awaitility.Awaitility;
45
import org.hamcrest.CoreMatchers;
56
import org.hamcrest.Matchers;
67
import org.hamcrest.core.IsCollectionContaining;
@@ -82,7 +83,6 @@
8283
import static org.hamcrest.Matchers.greaterThan;
8384
import static org.hamcrest.Matchers.hasSize;
8485
import static org.hamcrest.Matchers.isEmptyString;
85-
import static org.hamcrest.Matchers.lessThan;
8686
import static org.hamcrest.Matchers.lessThanOrEqualTo;
8787
import static org.hamcrest.core.StringContains.containsString;
8888
import static org.junit.Assert.assertEquals;
@@ -121,6 +121,9 @@ public static void loadConfig() {
121121
config = ZendeskConfig.load();
122122
assumeThat("We have a configuration", config, notNullValue());
123123
assumeThat("Configuration has an url", config.getProperty("url"), not(isEmptyString()));
124+
Awaitility.setDefaultTimeout(2, TimeUnit.MINUTES);
125+
Awaitility.setDefaultPollDelay(10, TimeUnit.SECONDS);
126+
Awaitility.setDefaultPollInterval(20, TimeUnit.SECONDS);
124127
}
125128

126129
public void assumeHaveToken() {
@@ -1889,8 +1892,8 @@ private JobStatus waitJobCompletion(final JobStatus result) {
18891892
assertNotNull(result.getId());
18901893
assertNotNull(result.getStatus());
18911894

1892-
// Let's wait for its completion (5 seconds max)
1893-
await().atMost(10, TimeUnit.SECONDS).until(() ->
1895+
// Let's wait for its completion (2 minutes max)
1896+
await().until(() ->
18941897
instance.getJobStatus(result).getStatus() == JobStatus.JobStatusEnum.completed);
18951898

18961899
// Let's validate and return the completed result
@@ -1909,7 +1912,7 @@ private JobStatus waitJobCompletion(final JobStatus result) {
19091912
*/
19101913
private void waitTicketDeleted(long ticketId) {
19111914
// Wait for the confirmation
1912-
await().atMost(10, TimeUnit.SECONDS).until(() -> StreamSupport
1915+
await().until(() -> StreamSupport
19131916
.stream(instance.getDeletedTickets("id", SortOrder.DESCENDING).spliterator(), false)
19141917
.map(DeletedTicket::getId)
19151918
.collect(Collectors.toList())
@@ -1923,7 +1926,7 @@ private void waitTicketDeleted(long ticketId) {
19231926
*/
19241927
private void waitTicketsDeleted(Long[] ticketsIds) {
19251928
// Wait for the confirmation
1926-
await().atMost(10, TimeUnit.SECONDS).until(() -> StreamSupport
1929+
await().until(() -> StreamSupport
19271930
.stream(instance.getDeletedTickets("id", SortOrder.DESCENDING).spliterator(), false)
19281931
.map(DeletedTicket::getId)
19291932
.collect(Collectors.toList())

0 commit comments

Comments
 (0)