Skip to content

Commit 878f885

Browse files
authored
Use @_implementationOnly import for FirebaseCoreExtension (#9887)
Using a regular import caused internal Core APIs to be surfaced to end users.
1 parent 3827b43 commit 878f885

File tree

6 files changed

+16
-4
lines changed

6 files changed

+16
-4
lines changed

FirebaseFunctions/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# 9.2.0
22
- [fixed] Fixed regressions in error code processing introduced in 9.0.0. (#9855)
3+
- [fixed] Importing FirebaseFunctions no longer exposes internal FirebaseCore APIs. (#9884)
34

45
# 9.0.0
56
- [changed] The FirebaseFunctionsSwift library has been removed. All of its APIs are now included

FirebaseFunctions/Sources/Functions.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import Foundation
1616
import FirebaseAppCheckInterop
1717
import FirebaseAuthInterop
1818
import FirebaseCore
19-
import FirebaseCoreExtension
2019
import FirebaseMessagingInterop
2120
import FirebaseSharedSwift
2221
#if COCOAPODS
@@ -25,6 +24,9 @@ import FirebaseSharedSwift
2524
import GTMSessionFetcherCore
2625
#endif
2726

27+
// Avoids exposing internal FirebaseCore APIs to Swift users.
28+
@_implementationOnly import FirebaseCoreExtension
29+
2830
/// File specific constants.
2931
private enum Constants {
3032
static let appCheckTokenHeader = "X-Firebase-AppCheck"

FirebaseFunctions/Sources/Internal/FunctionsComponent.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,11 @@ import Foundation
1616
import FirebaseAppCheckInterop
1717
import FirebaseAuthInterop
1818
import FirebaseCore
19-
import FirebaseCoreExtension
2019
import FirebaseMessagingInterop
2120

21+
// Avoids exposing internal FirebaseCore APIs to Swift users.
22+
@_implementationOnly import FirebaseCoreExtension
23+
2224
@objc(FIRFunctionsProvider)
2325
protocol FunctionsProvider {
2426
@objc func functions(for app: FirebaseApp,

FirebaseStorage/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# 9.2.0
2+
- [fixed] Importing FirebaseStorage no longer exposes internal FirebaseCore APIs. (#9884)
3+
14
# 9.0.0
25
- [changed] The FirebaseStorageSwift library has been removed. All of its APIs are now included
36
in the FirebaseStorage library. Please remove references to FirebaseStorageSwift from Podfiles and

FirebaseStorage/Sources/Storage.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@ import Foundation
1616

1717
import FirebaseStorageInternal
1818
import FirebaseCore
19-
import FirebaseCoreExtension
2019
import FirebaseAppCheckInterop
2120
import FirebaseAuthInterop
2221

22+
// Avoids exposing internal FirebaseCore APIs to Swift users.
23+
@_implementationOnly import FirebaseCoreExtension
24+
2325
/**
2426
* Firebase Storage is a service that supports uploading and downloading binary objects,
2527
* such as images, videos, and other files to Google Cloud Storage. Instances of `Storage`

FirebaseStorage/Sources/StorageComponent.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ import Foundation
1616
import FirebaseAppCheckInterop
1717
import FirebaseAuthInterop
1818
import FirebaseCore
19-
import FirebaseCoreExtension
19+
20+
// Avoids exposing internal FirebaseCore APIs to Swift users.
21+
@_implementationOnly import FirebaseCoreExtension
2022

2123
@objc(FIRStorageProvider)
2224
protocol StorageProvider {

0 commit comments

Comments
 (0)