-
Notifications
You must be signed in to change notification settings - Fork 1.6k
FR: Adding tvOS Support #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, i am working on it. 1.) support GoogleToolBoxForMac for tvOS, which should work on my fork: Pull request for it: so I am now able to Run Firebase/Core. Next I wanted to run Firebase/Database. Here you have leveldb-library as dependency. But I wasn't really able to find a podspec in your Repo, I found it on https://github.com/CocoaPods/Specs/blob/master/Specs/a/d/a/leveldb-library/1.18.3/leveldb-library.podspec.json but you don't even use your own version it's a fork from https://github.com/matehat/leveldb.git. So I also forked that Repo and wrote my own Podspec: Pod::Spec.new do |s|
s.name = 'leveldb-library'
s.version = '1.18.3'
s.author = 'The LevelDB Authors'
s.license = 'New BSD'
s.homepage = 'https://github.com/google/leveldb'
s.source = { :git => 'https://github.com/mariohahn/leveldb.git',
:tag => "v1.18.1" }
s.summary = 'A fast key-value storage library'
s.description = <<-DESC
LevelDB is a fast key-value storage library written at Google that provides an ordered mapping from string keys to string values.
DESC
s.osx.deployment_target = '10.7'
s.ios.deployment_target = '5.0'
s.tvos.deployment_target = '9.0'
s.requires_arc = false
s.header_dir = "leveldb"
s.source_files =
'db/*.{cc}',
'port/*.{cc}',
'table/*.{cc}',
'port/*.{cc}',
'util/*.{cc}',
'include/leveldb/*.h'
s.compiler_flags =
'-DOS_MACOSX',
'-DLEVELDB_PLATFORM_POSIX'
s.preserve_paths =
'db',
'port',
'table',
'util'
s.exclude_files =
'**/*_test.cc',
'**/*_bench.cc',
'port/win'
s.xcconfig = {
'CC' => '"clang"',
'CXX' => '"clang++"',
'HEADER_SEARCH_PATHS' => '"\"${PODS_ROOT}/leveldb-library/\" \"${PODS_ROOT}/leveldb-library/include\""',
'WARNING_CFLAGS' => '"-Wno-shorten-64-to-32"',
'OTHER_LDFLAGS' => '"-lc++"'
}
end But I am not able to run it successfully :( Why are you using a fork of your own Product? |
Hi Mario, Thanks for diving in! As you've noticed, the leveldb-library dependency is somewhat stale and we plan to get it updated. However, we don't expect the stale dependency to cause any issues for Firebase/Database. What is the build issue you're seeing? |
Maybe my podspec isn't correct. /var/folders/g1/wmtly35542vbzmmdxg4y3nwc0000gn/T/CocoaPods/Lint/Pods/leveldb-library/util/coding.cc:5:10: fatal error: 'util/coding.h' file not found ** BUILD FAILED ** The following build commands failed: Analyzed 1 podspec. |
It looks like you're running into CocoaPods/CocoaPods#5152 - CocoaPods 1.x currently does not support libraries with C++ headers. The workaround is use the new option --skip-import-validation. |
But I am sure that I am doing something wrong because --skip-import-validation is a new com but https://github.com/matehat/leveldb.git created the podspec months ago when the com wasn't even available. But he hasn't committed his podspec 😞 |
The original podspec was probably validated with CocoaPods 0.x |
even with --skip-import-validation it's not working.
|
It looks like there are extra quotes in the xcconfig above. It runs pod spec lint with only a warning about the version if I replace it with the following:
|
Setup Podfile dependencies and add Open Source Xcode targets and schemes for ApiTests, EarlGreyTests, and FirebaseAuthUnitTests.
Hi! How is tvOS support coming? Was so excited to see the macOS support pushed! |
Do you have any progress on tvOS support? |
tvOS is not on the near-term Firebase roadmap, but we'd be happy to review and accept PRs if anyone wants to pick up where @mariohahn left off. |
Hi! I see there is some activity in https://github.com/firebase/firebase-ios-sdk/tree/tvOS_master branch, does it mean there is a change we're getting tvOS support any time soon? |
Unfortunately we really can't promise timelines. Yes there's some work underway but other priorities might come up that halt our progress on it. As always, PRs welcome :-). |
tvOS Community support for Core, Auth, Database and Storage landed in #590 along with a tvOS sample app. See https://github.com/firebase/firebase-ios-sdk#community-supported-efforts. |
WOW. Can't wait to see Remote config for tvOS...
…On Wed, Jan 3, 2018 at 3:15 PM, Paul Beusterien ***@***.***> wrote:
tvOS Community support for Core, Auth, Database and Storage landed in #590
<#590> along with a tvOS
sample app. See https://github.com/firebase/firebase-ios-sdk#community-
supported-efforts.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD0FZo9NlTQcHtuQl0n7qfl8Jx7Tz7jks5tG9_cgaJpZM4Ned5V>
.
|
I'm might need to look into using Firebase (database specifically) on tvOS soon... just sayin' thanks for any work so far, in advance... |
Got auth/database working in a simple test app (actually kind of a port of existing iOS app). Seems to work. Thanks again. |
Because Firebase Analytics is dependent on Google Analytics and Google Analytics is not open source and not supporting tvOS, Firebase Analytics won't be available on tvOS. Is that right? |
Firebase Analytics does not depend upon Google Analytics, and neither are open source. Open source is not a requirement to add support for tvOS - however there are no public plans to make Firebase Analytics available for tvOS. cc: @baolocdo |
Question about Firebase Analytics for tvOS. I don't understand. Can I use last version of FirebaseCore for tvOS for Firebase Analytics? Now I add sdk to my tvOS app and try to start it, But every time I have "1671911] 5.0.0 - [Firebase/Core][I-COR000022] Firebase Analytics is not available." |
You can safely ignore that warning. Firebase Analytics is not available for tvOS. I'll send a PR to get rid of the warning. |
I just got Firebase/Database working on tvOS by following the above example app and wanted to provide a TL;DR Podfile for those just getting started with Firebase/Database on tvOS:
Thanks to those who contributed to this thread! |
Any particular reason why functions are not supported on TvOS? I just modified the FirebaseFunctions.podspec to add support for TvOS and MacOS and the module build just fine. thanks |
@acerbetti It just hasn't been implemented and tested yet. We'll be happy to review a PR. It should be a lot easier after the recently submitted testspec PR #1864 since no Xcode project setup is required for testing. |
@acerbetti I just made the #2506 to add tvOS and macOS for FirebaseFunctions. You're right that it's a seamless port. Thanks for the push. |
That's great, I was planning to test it better today and provide a PR, but you beat me. thanks |
Oh sorry for beating you to it. If you have some real-life tests that go beyond what's in the packaged unit and integration tests, that would still be appreciated. |
@paulb777 Using the latest gRPC-C++ & gRPC-Core I was able to get Firestore running and returning data. Only error I came across was sigaltstack which isn't available on tvOS used here... firebase-ios-sdk/Firestore/third_party/abseil-cpp/absl/debugging/failure_signal_handler.cc Lines 153 to 155 in f250f50
|
@paulb777 If you have any thoughts on an adjustment to the snippet below for tvOS, as its third-party I'm hesitant to simply comment it out or wrap in a tvOS check. firebase-ios-sdk/Firestore/third_party/abseil-cpp/absl/debugging/failure_signal_handler.cc Lines 153 to 155 in f250f50
@samsidd This is using a fork of master 👍 |
@ay8s Checking TARGET_OS_TV should be fine |
My tvOS app is not connecting to the Firebase Console. I follow all the steps taking into account from giving the ID bundle, to installing the pods but when it reaches step 5 it never connects. Has anyone the same problem? Is there an extra step necessary for tvOS ? |
@erickavb just wanted to say thanks for blazing the path for the rest of us with Firestore on Apple TV. We are going to have migrate from Firebase DB to Firestore soon to overcome the 100k concurrent limit of Firebase DB. |
@erickavb re: not connecting to the Firebase Console. When the console waits for the "connect" step it is looking for a specific Analytics event which will never happen since Analytics isn't currently supported on tvOS. It's safe to ignore this warning and things should work as expected. |
Going to close this since we now have community tvOS for most of Firebase and specific issues for missing coverage like #2011. |
Hi everyone, I am Mayank, a Product Manager at Firebase. I am excited to share that we are in the process of improving Firebase SDKs to support additional Apple platforms. If you are already using Firebase in your app which supports multiple Apple platforms (tvOS/macOS/Catalyst/watchOS) or are looking to add support for those platforms, we'd love to get your feedback. If you're interested in chatting with us and getting early access to future updates, please sign up using this form : https://forms.gle/odseGnshb3Jq8wuz5 Once approved, we will share further information on how to proceed. Thank you! |
I'm making use of a old version of the Firebase SDK which tweaked the v2 SDK to allow it to be used in tvOS applications.
This is working well right now but missing out on some additional features that have been added since, also worried using such an old SDK may stop working in the production app in the future.
I'm aware there would be significant changes needed due to the limitations on persistent storage and happy to have data load on launch as it is doing in the current solution. Would love to kick off a discussion around this.
The text was updated successfully, but these errors were encountered: