Logout action triggers a GET of the homepage twice

[BertKoor]

While investigating an issue reported on the forum I discovered that after a logout the homepage is fetched twice. I suspect some servers may be configured with a rule engine such that the second request gets a response 403-Forbidden.

I'm surprised to see the first request has type 'fetch' (an earlier test showed it with size zero) while the second has type 'document'.

I have tested other actions which do a POST request (login, quick search) but these get a single response.

I suspect there's something wrong with the promise (consumer twice?)

Screenshots of logging out at the demo server:

---

---

---

Same as performed on the server of jantony:

---

---

[BertKoor]

Found the cause. The Logout request handler responds with

return redirect(route(HomePage::class));

But also in the ModuleThemeTrait where the logout action is defined:

'data-wt-reload-url' => route(HomePage::class)

So the browser does both.

After testing removal of either I have concluded it's best to let the handler respond with 204-NoContent and let property wtReloadUrl then do its magic. Otherwise webtrees might try to fetch a private page and presents a login dialog.

Will put the fix in a PR when affected user reports back it indeed fixes the issue.