Improvement - Using update instead of looping over objects

EliakinCosta · EliakinCosta · commit d141699aedba · 2020-01-08T17:30:00.000-03:00
diff --git a/dbaas/notification/tasks.py b/dbaas/notification/tasks.py
@@ -789,9 +789,7 @@ def migrate_engine(self, database, user, task, since_step=0):
         )
 
         # Setting new Instance Type for all instances
-        for instance in infra.instances.all():
-            instance.instance_type = instance_type
-            instance.save()
+        infra.instances.update(instance_type=instance_type)
 
         database_migrate_engine_obj.set_success()
         task.update_status_for(TaskHistory.STATUS_SUCCESS, 'Done')

Original file line number	Diff line number	Diff line change
`@@ -789,9 +789,7 @@ def migrate_engine(self, database, user, task, since_step=0):`
`789`	`789`	`)`
`790`	`790`
`791`	`791`	`# Setting new Instance Type for all instances`
`792`		`- for instance in infra.instances.all():`
`793`		`- instance.instance_type = instance_type`
`794`		`- instance.save()`
	`792`	`+ infra.instances.update(instance_type=instance_type)`
`795`	`793`
`796`	`794`	`database_migrate_engine_obj.set_success()`
`797`	`795`	`task.update_status_for(TaskHistory.STATUS_SUCCESS, 'Done')`