A more complex check for boundary plus and minus

[AkbarZafar]

Describe the bug
A clear and concise description of what the bug is.
The boundary check for when symmetry is available does an equality check which disregards any additional fields that users may have set, causing the equality check to fail even if the relevant values are the same

https://github.com/flexcompute/tidy3d/blob/develop/tidy3d/components/simulation.py#L424

To Reproduce
Steps to reproduce the behavior:

1. create 2 BoundaryEdge types
2. add a name field in each BoundaryEdge object, ie. "x+" and "x-"
3. doing an equality check on the 2 objects will fail due to the name field even if all the required values are equal

Expected behavior
A clear and concise description of what you expected to happen.
The boundary check for ax_bounds.plus and ax_bounds.minus should only compare the relevant fields and not a comparison of the entire plus and minus objects.

[yaugenst-flex]

Hey @AkbarZafar, thanks for reaching out and for the clear and concise bug report.

It's a good point, and I agree that for the specific case of the symmetry validator, the check is currently too strict.

I want to clarify that we will not be changing the general equality check (==) because the default behavior of comparing all fields, including name, is the correct and expected functionality for a generic equality comparison.

However, you are right that the symmetry validator should not be using this generic comparison. Its purpose is to ensure physical compatibility for the symmetry condition, and the name field is irrelevant for that specific check.

Thanks again for bringing this to our attention! We'll have this fixed in an upcoming release.

[AkbarZafar]

Hi @yaugenst-flex, thank you for looking into this! When can we expect the next release?

[tylerflex]

@AkbarZafar we just released 2.8.5 today. So it might be a few weeks.