-
Notifications
You must be signed in to change notification settings - Fork 1.7k
config: error configure_plugins_type on invalid properties #10296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stoksc
wants to merge
1
commit into
fluent:master
Choose a base branch
from
stoksc:stoksc/invalid-input-property
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82e5741
to
ea1ea67
Compare
511c426
to
e85d7f7
Compare
e85d7f7
to
ffffa03
Compare
677fc73
to
df46f10
Compare
df46f10
to
a84efbe
Compare
a84efbe
to
2ab5cc4
Compare
Signed-off-by: Bradley Laney <[email protected]>
2ab5cc4
to
1df2c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, when a plugin configuration contains an invalid property,
configure_plugins_type
returns an error which ultimately crashes fluentbit, instead of only printing an error log and continuing on. The change also fixes a small issue wherename
was printed byflb_error
after it was freed. To properly test this change and get the test to pass with-DSANITIZE_ADDRESS=On
on all platforms, I had to updateconfigure_plugins_type
to free objects that it fails to instantiate.Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Added tests, so the configuration files and outputs can be found there.
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.