Merge pull request gruntwork-io#25 from 06kellyjac/shellcheck_optionals

Shellcheck optionals

Author: yorinasub17

README.md

@@ -125,6 +125,19 @@ Now when the pre-commit hook runs, it will call `helm lint` with both `linter_va
 helm lint -f values.yaml -f linter_values.yaml .
 ```
 
+## Shellcheck Arguments
+
+To enable optional shellcheck features you can use the `--enable` flag.
+Other shellcheck flags can not be passed through.
+
+```yaml
+repos:
+  - repo: https://github.com/gruntwork-io/pre-commit
+    rev: <VERSION>
+    hooks:
+      - id: shellcheck
+        args: ["--enable require-variable-braces,deprecate-which"]
+```
 
 
 ## License

hooks/shellcheck.sh

@@ -8,17 +8,43 @@ set -e
 export PATH=$PATH:/usr/local/bin
 
 exit_status=0
+enable_list=""
 
-for file in "$@"; do
- if (head -1 "$file" |grep '^#!.*sh'>/dev/null); then
+parse_arguments() {
+	while (($# > 0)); do
+		# Grab param and value splitting on " " or "=" with parameter expansion
+		local PARAMETER="${1%[ =]*}"
+		local VALUE="${1#*[ =]}"
+		if [[ "$PARAMETER" == "$VALUE" ]]; then VALUE="$2"; fi
+		shift
+		case "$PARAMETER" in
+		--enable)
+			enable_list="$enable_list $VALUE"
+			;;
+		-*)
+			echo "Error: Unknown option: $PARAMETER" >&2
+			exit 1
+			;;
+		*)
+			files="$files $PARAMETER"
+			;;
+		esac
+	done
+	enable_list="${enable_list## }" # remove preceeding space
+}
 
-    if ! shellcheck "$file"; then
-        exit_status=1
-    fi
- elif [[ "$file" =~ \.sh$|bash$ ]]; then
-      echo "$file: missing shebang"
-      exit_status=1
- fi
+parse_arguments "$@"
+
+for FILE in $files; do
+	SHEBANG_REGEX='^#!\(/\|/.*/\|/.* \)\(\(ba\|da\|k\|a\)*sh\|bats\)$'
+	if (head -1 "$FILE" | grep "$SHEBANG_REGEX" >/dev/null); then
+		if ! shellcheck ${enable_list:+ --enable="$enable_list"} "$FILE"; then
+			exit_status=1
+		fi
+	elif [[ "$FILE" =~ .+\.(sh|bash|dash|ksh|ash|bats)$ ]]; then
+		echo "$FILE: missing shebang"
+		exit_status=1
+	fi
 done
 
 exit $exit_status