Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iCamilo/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: frankm/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 9 files changed
  • 3 contributors

Commits on Sep 21, 2020

  1. Update to recommended settings (Xcode 12)

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    61f0cd5 View commit details
    Browse the repository at this point in the history

  2. Replace #file with the new #filePath

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f00d440 View commit details
    Browse the repository at this point in the history

  3. Update CI config to use Xcode 12

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    9bdb08b View commit details
    Browse the repository at this point in the history

  4. Update README

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    ac0f5c1 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #35 from essentialdevelopercom/xcode12 

    Update to Xcode 12
    @mapostolakis
    mapostolakis authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    a8ca4b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. ability to load url more than once

    @frankm
    frankm committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    ae7660e View commit details
    Browse the repository at this point in the history

  2. deliver 'connectivity error' on client error

    @frankm
    frankm committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    4625471 View commit details
    Browse the repository at this point in the history

  3. deliver 'invalid data' error for non 200 HTTP response

    @frankm
    frankm committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    f7323e9 View commit details
    Browse the repository at this point in the history

  4. deliver empty array, on 200 HTTP response given empty JSON list

    @frankm
    frankm committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    8e73309 View commit details
    Browse the repository at this point in the history

  5. deliver items, Feed Images, on 200 HTTP response given JSON list

    @frankm
    frankm committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    8b1c3b8 View commit details
    Browse the repository at this point in the history

  6. does not deliver result after 'RemoteFeedLoader' has been deallocated

    @frankm
    frankm committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    ffa84fe View commit details
    Browse the repository at this point in the history

  7. refactor JSON decoding logic to separate function

    @frankm
    frankm committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    e19f8f1 View commit details
    Browse the repository at this point in the history
Loading