Incorrect rounding on Credit Notes

[WillemJansen]

Information about bug

Dear ERPNext team,
first of a a big thank you for creating such a powerful and elegant software!

Basic premise is a somewhat peculiar rounding strategy for negative numbers resulting in inconsistent credit notes:

Situation:
The total values of a credit note differs from the original sales invoice, often just by a single cent. This is induced by the total value per item (price * quantity) gives minimally different results, depending on whether the quantity is positive or negative, which it is by default on credit notes.

Root cause:
Rounding strategy for negative numbers

• "+12,345 EUR" for an item on the sales invoice is rounded up to "+12,35 EUR" (correctly)
• "-12,345 EUR" for an item on the credit note is rounded up to "-12,34 EUR (definitely inconsistent, likely incorrect)

Solution:
To ensure consistency of invoices and credit notes, employ a rounding strategy that is not affected by the sign of the value.

Module

accounts

Version

Installed Apps
ALYF Banking: v15.17.0 (HEAD)

ERPNext: v15.61.1 (HEAD)

ERPNext Gocardless Bank: v1.0.0 (HEAD)

European e-Invoice: v15.9.0 (HEAD)

Frappe Framework: v15.68.1 (HEAD)

Frappe HR: v15.45.2 (HEAD)

Installation method

FrappeCloud

Relevant log output / Stack trace / Full Error Message.

[DipenFrappe]

Can you confirm what the rounding method is in your case

[WillemJansen]

Rounding method was not set, will set it to commercial & check once more!
Regardless, I feel that any inconsistency between original invoice and credit note should be avoided...

Will report back!

[DipenFrappe]

I checked it is working fine. 112.5 rounding to 113 and 112.49 to 112 in both the sales invoice and sales return/credit note.