Skip to content
This repository was archived by the owner on Jan 3, 2019. It is now read-only.

Commit c479f5e

Browse files
committed
Merge pull request #296 from fsharp/fsi-fixes
Fsi fixes
2 parents 7da303c + 5eb07fb commit c479f5e

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

MonoDevelop.FSharpBinding/FSharpTextEditorCompletion.fs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ type FsiParameterHintingData (tooltip:MonoDevelop.FSharp.Shared.ParameterTooltip
572572
match tooltip with
573573
| MonoDevelop.FSharp.Shared.ParameterTooltip.ToolTip (signature, doc, parameters) ->
574574
let signature, parameterName =
575-
if paramIndex = -1 then
575+
if paramIndex = -1 || paramIndex < parameters.Length - 1 then
576576
Highlight.syntaxHighlight signature, null
577577
else
578578
let paramName = parameters.[paramIndex]
@@ -639,7 +639,10 @@ module ParameterHinting =
639639
tooltips
640640
|> List.map (fun meth -> FsiParameterHintingData (meth) :> ParameterHintingData)
641641
|> ResizeArray.ofList
642-
return ParameterHintingResult(hintingData, startOffset)
642+
if hintingData.Count > 0 then
643+
return ParameterHintingResult(hintingData, startOffset)
644+
else
645+
return ParameterHintingResult.Empty
643646
| _ -> return ParameterHintingResult.Empty
644647
| _ -> return ParameterHintingResult.Empty
645648
else

MonoDevelop.FSharpBinding/Services/InteractiveSession.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ type InteractiveSession() =
121121

122122
member x.Kill() =
123123
if not fsiProcess.HasExited then
124-
sendCommand "#q"
124+
x.SendInput "#q;;"
125125
for i in 0 .. 10 do
126126
if not fsiProcess.HasExited then
127127
LoggingService.logDebug "Interactive: waiting for process exit after #q... %d" (i*200)

0 commit comments

Comments
 (0)