Skip to content

Commit c95caae

Browse files
committed
Merge pull request nkrode#53 from allanparsons/master
Updated to support Redis instances w/ password challenges
2 parents 5116c7b + 9406510 commit c95caae

File tree

4 files changed

+27
-12
lines changed

4 files changed

+27
-12
lines changed

src/api/controller/ServerListController.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def read_server_config(self):
1616

1717
for server in redis_servers:
1818
server_id = "%(server)s:%(port)s" % server
19-
s = dict(server=server['server'], port=server['port'], id=server_id)
19+
s = dict(server=server['server'], port=server['port'], password=server['password'], id=server_id)
2020
server_list.append(s)
2121

2222
return server_list

src/dataprovider/redisprovider.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,11 @@ def __init__(self):
1313
stats_server = settings.get_redis_stats_server()
1414
self.server = stats_server["server"]
1515
self.port = stats_server["port"]
16-
self.conn = redis.StrictRedis(host=self.server, port=self.port, db=0)
16+
if stats_server["password"]:
17+
self.password = stats_server["password"]
18+
else:
19+
self.password = None
20+
self.conn = redis.StrictRedis(host=self.server, port=self.port, db=0, password=self.password)
1721

1822
def save_memory_info(self, server, timestamp, used, peak):
1923
"""Saves used and peak memory stats,

src/redis-live.conf

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,23 @@
11
{
22
"RedisServers":
33
[
4-
{
5-
"server": "127.0.0.1",
6-
"port" : 6379
7-
}
4+
{
5+
"server": "154.17.59.99,
6+
"port" : 6379,
7+
},
8+
{
9+
"server": "localhost",
10+
"port" : 6380,
11+
"password" : "some-password"
12+
}
13+
}
814
],
915

1016
"DataStoreType" : "redis",
1117

1218
"RedisStatsServer":
1319
{
14-
"server" : "127.0.0.1",
15-
"port" : 6381
20+
"server" : "ec2-184-72-166-144.compute-1.amazonaws.com",
21+
"port" : 6385
1622
}
1723
}

src/redis-monitor.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,15 +246,20 @@ def run(self, duration):
246246
"""
247247
redis_servers = settings.get_redis_servers()
248248

249+
249250
for redis_server in redis_servers:
250-
monitor = MonitorThread(redis_server["server"], redis_server["port"],
251-
redis_server.get("password", None))
251+
252+
if redis_server["password"]:
253+
redis_password = redis_server["password"]
254+
else:
255+
redis_password = None
256+
257+
monitor = MonitorThread(redis_server["server"], redis_server["port"], redis_password)
252258
self.threads.append(monitor)
253259
monitor.setDaemon(True)
254260
monitor.start()
255261

256-
info = InfoThread(redis_server["server"], redis_server["port"],
257-
redis_server.get("password", None))
262+
info = InfoThread(redis_server["server"], redis_server["port"], redis_password)
258263
self.threads.append(info)
259264
info.setDaemon(True)
260265
info.start()

0 commit comments

Comments
 (0)