@ pallets-eco#25 | Special methods should work with Python 3.5 type hints

Author: hoatle

flask_classful.py

@@ -357,7 +357,11 @@ def get_interesting_members(base_class, cls):
 def get_true_argspec(method):
     """Drills through layers of decorators attempting to locate the actual argspec for the method."""
 
-    argspec = inspect.getargspec(method)
+    try:
+        argspec = inspect.getargspec(method)
+    except ValueError:
+        argspec = inspect.getfullargspec(method)
+
     args = argspec[0]
     if args and args[0] == 'self':
         return argspec

setup.cfg

@@ -0,0 +1,3 @@
+[nosetests]
+where=test_classful
+py3where=.

setup.py

@@ -37,7 +37,7 @@ def find_version(*file_paths):
     url='https://github.com/teracyhq/flask-classful',
     license='BSD',
     author='Freedom Dumlao & Teracy, Inc',
-    author_email='teracyhq@teracy.com',
+    author_email='hq@teracy.com',
     description='Class based views for Flask',
     long_description=__doc__,
     py_modules=['flask_classful'],

test_classful_py3/test_type_hints.py

@@ -0,0 +1,41 @@
+import sys
+
+import json
+from flask import Flask
+from flask_classful import FlaskView, route
+from nose.tools import *
+
+
+# python3 only
+
+class TypingView(FlaskView):
+
+    def index(self):
+        return "Index"
+
+    @route('/<id>', methods=['POST'])
+    def post(self, id: str) -> str:
+        return "Post"
+
+    def patch(self, id: str) -> str:
+        return "Patch"
+
+
+app = Flask('typing-app')
+TypingView.register(app)
+client = app.test_client()
+
+
+def test_index():
+    resp = client.get('/typing/')
+    eq_(b"Index", resp.data)
+
+
+def test_post():
+    resp = client.post('/typing/123')
+    eq_(b"Post", resp.data)
+
+
+def test_patch():
+    resp = client.patch('/typing/123')
+    eq_(b"Patch", resp.data)