Skip to content

Commit 067b886

Browse files
authored
Merge pull request #570 from kiptix/master
#569 Secure Installation should use variable mysql_daemon
2 parents 210caa2 + b920c48 commit 067b886

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

tasks/secure-installation.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,14 @@
2222
and (mysql_install_packages | bool or mysql_user_password_update)
2323
2424
- name: Disallow root login remotely
25-
ansible.builtin.command: 'mysql -NBe "{{ item }}"'
25+
ansible.builtin.command: '{{ mysql_daemon }} -NBe "{{ item }}"'
2626
with_items:
2727
- DELETE FROM mysql.user WHERE User='{{ mysql_root_username }}' AND Host NOT IN ('localhost', '127.0.0.1', '::1')
2828
changed_when: false
2929

3030
- name: Get list of hosts for the root user.
31-
ansible.builtin.command: mysql -NBe
31+
ansible.builtin.command: >
32+
{{ mysql_daemon }} -NBe
3233
"SELECT Host
3334
FROM mysql.user
3435
WHERE User = '{{ mysql_root_username }}'
@@ -43,7 +44,7 @@
4344
# Set root password for MySQL >= 8.4 and MariaDB ≥ 10.4
4445
- name: Update MySQL root authentication via socket for localhost (Linux, MySQL ≥ 8.4)
4546
ansible.builtin.shell: >
46-
mysql -u root -NBe
47+
{{ mysql_daemon }} -u root -NBe
4748
"ALTER USER '{{ mysql_root_username }}'@'{{ item }}'
4849
IDENTIFIED {{ (mysql_daemon == 'mariadb') | ternary('VIA unix_socket', 'WITH auth_socket') }}; FLUSH PRIVILEGES;"
4950
no_log: "{{ mysql_hide_passwords }}"
@@ -59,7 +60,7 @@
5960
# Set root password for 5.7.x. ≤ MySQL < 8.4 and MariaDB ≥ 10.4
6061
- name: Update MySQL root password for localhost root account (5.7.x ≤ MySQL < 8.4)
6162
ansible.builtin.shell: >
62-
mysql -u root -NBe
63+
{{ mysql_daemon }} -u root -NBe
6364
"ALTER USER '{{ mysql_root_username }}'@'{{ item }}'
6465
IDENTIFIED {{ (mysql_daemon == 'mariadb') | ternary('VIA', 'WITH') }} mysql_native_password
6566
BY '{{ mysql_root_password }}'; FLUSH PRIVILEGES;"
@@ -78,7 +79,7 @@
7879
# Set root password for MySQL < 5.7.x.
7980
- name: Update MySQL root password for localhost root account (< 5.7.x).
8081
ansible.builtin.shell: >
81-
mysql -NBe
82+
{{ mysql_daemon }} -NBe
8283
'SET PASSWORD FOR "{{ mysql_root_username }}"@"{{ item }}" = PASSWORD("{{ mysql_root_password }}"); FLUSH PRIVILEGES;'
8384
no_log: "{{ mysql_hide_passwords }}"
8485
with_items: "{{ mysql_root_hosts.stdout_lines|default([]) }}"
@@ -100,7 +101,8 @@
100101
- mysql_copy_root_user_mycnf
101102

102103
- name: Get list of hosts for the anonymous user.
103-
ansible.builtin.command: mysql -NBe "SELECT Host FROM mysql.user WHERE User = ''"
104+
ansible.builtin.command: >
105+
{{ mysql_daemon }} -NBe "SELECT Host FROM mysql.user WHERE User = ''"
104106
register: mysql_anonymous_hosts
105107
changed_when: false
106108
check_mode: false

0 commit comments

Comments
 (0)