Skip to content

Commit 34275d0

Browse files
committed
Check the pull_request.title (for squash commits)
1 parent 686a53e commit 34275d0

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

dist/index.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1337,7 +1337,6 @@ function run() {
13371337
const commitsListed = yield octokit.rest.pulls.listCommits({
13381338
owner: repo.owner.login,
13391339
repo: repo.name,
1340-
// eslint-disable-next-line @typescript-eslint/camelcase
13411340
pull_number: pr.number
13421341
});
13431342
let commits = commitsListed.data;
@@ -1352,11 +1351,11 @@ function run() {
13521351
// const commitsString = core.getInput('commits')
13531352
// const commits = JSON.parse(commitsString)
13541353
const checkerArguments = inputHelper.getInputs();
1354+
inputHelper.checkArgs(checkerArguments);
13551355
const preErrorMsg = core.getInput('pre_error');
13561356
const postErrorMsg = core.getInput('post_error');
13571357
const failed = [];
13581358
for (const { commit, sha } of commits) {
1359-
inputHelper.checkArgs(checkerArguments);
13601359
const errMsg = commitMessageChecker.checkCommitMessages(checkerArguments, commit.message);
13611360
if (errMsg) {
13621361
failed.push({ sha, message: errMsg });
@@ -1365,6 +1364,10 @@ function run() {
13651364
if (onePassAllPass === 'true' && commits.length > failed.length) {
13661365
return;
13671366
}
1367+
const errMsg = commitMessageChecker.checkCommitMessages(checkerArguments, pr.title);
1368+
if (errMsg) {
1369+
failed.push({ sha: 'pull request title', message: errMsg });
1370+
}
13681371
if (failed.length > 0) {
13691372
const summary = inputHelper.genOutput(failed, preErrorMsg, postErrorMsg);
13701373
core.setFailed(summary);

src/main.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,19 +68,18 @@ async function run(): Promise<void> {
6868
// const commitsString = core.getInput('commits')
6969
// const commits = JSON.parse(commitsString)
7070
const checkerArguments = inputHelper.getInputs()
71+
inputHelper.checkArgs(checkerArguments)
7172

7273
const preErrorMsg = core.getInput('pre_error')
7374
const postErrorMsg = core.getInput('post_error')
7475

7576
const failed = []
7677

7778
for (const {commit, sha} of commits) {
78-
inputHelper.checkArgs(checkerArguments)
7979
const errMsg = commitMessageChecker.checkCommitMessages(
8080
checkerArguments,
8181
commit.message
8282
)
83-
8483
if (errMsg) {
8584
failed.push({sha, message: errMsg})
8685
}
@@ -90,6 +89,14 @@ async function run(): Promise<void> {
9089
return
9190
}
9291

92+
const errMsg = commitMessageChecker.checkCommitMessages(
93+
checkerArguments,
94+
pr.title
95+
)
96+
if (errMsg) {
97+
failed.push({sha: 'pull request title', message: errMsg})
98+
}
99+
93100
if (failed.length > 0) {
94101
const summary = inputHelper.genOutput(failed, preErrorMsg, postErrorMsg)
95102
core.setFailed(summary)

0 commit comments

Comments
 (0)