Why is my code getting instrumented?

[gajus]

We are debugging performance issues that suddenly appeared in production, and I was surprised to see @opentelemetry/instrumentation-pg in our stack trace.

timeout expired Error
    at Client._connect (/srv/node_modules/.pnpm/[email protected]_patch_hash=5af002aa6dc8a236a1062ad3e392a2eb7d3c24db2b0c75fb2b7c7896a42ac164/node_modules/pg/lib/client.js:103:19)
    at /srv/node_modules/.pnpm/[email protected]_patch_hash=5af002aa6dc8a236a1062ad3e392a2eb7d3c24db2b0c75fb2b7c7896a42ac164/node_modules/pg/lib/client.js:184:12
    at new Promise (<anonymous>)
    at Client.connect (/srv/node_modules/.pnpm/[email protected]_patch_hash=5af002aa6dc8a236a1062ad3e392a2eb7d3c24db2b0c75fb2b7c7896a42ac164/node_modules/pg/lib/client.js:183:12)
    at Client.connect (/srv/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@opentelemetry/instrumentation-pg/build/src/instrumentation.js:130:37)
    at connect (/srv/node_modules/.pnpm/@[email protected][email protected]/node_modules/@slonik/pg-driver/dist/factories/createPgDriverFactory.js:201:38)
    at Object.createClient (/srv/node_modules/.pnpm/@[email protected][email protected]/node_modules/@slonik/driver/dist/factories/createDriverFactory.js:219:23)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:549:9)
    at process.processTimers (node:internal/timers:523:7)
    at async addConnection (/srv/node_modules/.pnpm/[email protected][email protected]/node_modules/slonik/dist/factories/createConnectionPool.js:63:32)
uncaughtException Error: timeout expired
    at Timeout._onTimeout (/srv/node_modules/.pnpm/[email protected]_patch_hash=5af002aa6dc8a236a1062ad3e392a2eb7d3c24db2b0c75fb2b7c7896a42ac164/node_modules/pg/lib/client.js:119:28)
    at listOnTimeout (node:internal/timers:588:17)
    at process.processTimers (node:internal/timers:523:7)

We initialize Sentry with:

skipOpenTelemetrySetup: true,
registerEsmLoaderHooks: false,

However, notice in the stack trace:

at Client.connect (/srv/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@opentelemetry/instrumentation-pg/build/src/instrumentation.js:130:37)

so why is there still instrumented code?

[gajus]

Turns out skipOtenTelemetrySetup is super misleading because the individual integrations (like Postgres) will still initialize the associated OTEL plugins.

This is how we fixed it:

-    integrations,
+    integrations: (integrations) => {
+      const allowedIntegrations = [
+        'InboundFilters',
+        'FunctionToString',
+        'LinkedErrors',
+        'RequestData',
+        'Console',
+        'Http',
+        'NodeFetch',
+        'OnUncaughtException',
+        'OnUnhandledRejection',
+        'ContextLines',
+        'LocalVariablesAsync',
+        'Context',
+      ];
+
+      if (SENTRY_TRACE === 'true') {
+        allowedIntegrations.push('Fastify', 'Graphql', 'Redis', 'Postgres');
+      }
+
+      const filteredIntegrations = integrations.filter((integration) =>
+        allowedIntegrations.includes(integration.name),
+      );
+
+      if (SENTRY_PROFILE === 'true') {
+        filteredIntegrations.push(nodeProfilingIntegration());
+      }
+
+      filteredIntegrations.push(
+        extraErrorDataIntegration({
+          captureErrorCause: true,
+          depth: 3,
+        }),
+        rewriteFramesIntegration({
+          root,
+        }),
+      );
+
+      return filteredIntegrations;
+    },