Skip to content

[RR7] Add vite plugin for updating sentry options in vite config #15520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chargome opened this issue Feb 27, 2025 · 1 comment · Fixed by #16197
Closed

[RR7] Add vite plugin for updating sentry options in vite config #15520

chargome opened this issue Feb 27, 2025 · 1 comment · Fixed by #16197
Assignees
@chargome @RulaKhaled
Labels
React Router Framework

Comments

@chargome
Copy link
Member

Description

Currently the user needs to pass the sentry config to both the vite config AND our vite plugin.
We could probably make this prettier by just adding a new plugin within our existing vite plugin that updates the global vite config with our sentry options (so that they are available for our buildEnd hook)

Ref #15406
@chargome chargome added the Package: react-router Issues related to the Sentry React Router SDK label Feb 27, 2025
@chargome chargome self-assigned this Feb 27, 2025
@mydea mydea removed the Task label Apr 14, 2025
@stephanie-anderson stephanie-anderson removed the Package: react-router Issues related to the Sentry React Router SDK label Apr 16, 2025
@RulaKhaled RulaKhaled self-assigned this May 5, 2025
@RulaKhaled RulaKhaled mentioned this issue May 5, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

A PR closing this issue has just been released 🚀

This issue was referenced by PR #16197, which was included in the 9.16.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chargome chargome

@RulaKhaled RulaKhaled

Labels
React Router Framework
Projects
None yet
Milestone
No milestone
4 participants
@mydea @stephanie-anderson @chargome @RulaKhaled