Skip to content

Express instrumentation uses / route for 404 routes #16203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 2 tasks
mydea opened this issue May 6, 2025 · 0 comments
Open
1 of 2 tasks

Express instrumentation uses / route for 404 routes #16203

mydea opened this issue May 6, 2025 · 0 comments
Labels
Bug Express

Comments

@mydea
Copy link
Member

mydea commented May 6, 2025 •
edited
Loading

A span emitted for a 404 route (e.g. /does-not-exist) has the http.route attribute incorrectly set to /, which results in it being grouped & named incorrectly.

This needs to be fixed upstream in otel for v4 of express: open-telemetry/opentelemetry-js-contrib#1947
@mydea mydea added the Bug label May 6, 2025
@mydea mydea mentioned this issue May 6, 2025
Merged
mydea added a commit that referenced this issue May 6, 2025
@mydea
test(node): Update express integration tests (#16204)
38316fd 
This updates naming etc. for express (v5) tests, and makes sure that we
test this in esm & cjs in a basic way.
It also adds test for handling of the root route (`/`) as well as 404,
where current failures are shown (see
#16203).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Express
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mydea