Skip to content

Google Cloud Serverless google-cloud-http.test.ts does not work in Node 24 #16238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AbhiPrasad opened this issue May 8, 2025 · 1 comment · Fixed by #16242
Closed

Google Cloud Serverless google-cloud-http.test.ts does not work in Node 24 #16238

AbhiPrasad opened this issue May 8, 2025 · 1 comment · Fixed by #16242
Labels
Bug Tests

Comments

@AbhiPrasad
Copy link
Member

Description

ref #16236 (comment)

When upgrading CI to account for Node 24, the Google Cloud Serverless Node 24 Unit Tests fail: https://github.com/getsentry/sentry-javascript/actions/runs/14913821156/job/41895096782?pr=16236

⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/integrations/google-cloud-http.test.ts [ test/integrations/google-cloud-http.test.ts ]
TypeError: Cannot read properties of undefined (reading 'prototype')
 ❯ Object.<anonymous> ../../node_modules/buffer-equal-constant-time/index.js:37:35
 ❯ Object.<anonymous> ../../node_modules/jwa/index.js:1:19

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed | 5 passed (6)
      Tests  31 passed (31)
   Start at  19:01:43
   Duration  3.99s (transform 1.32s, setup 0ms, collect 7.68s, tests 151ms, environment 2ms, prepare 787ms)

We need to fix this and re-enable google cloud serverless:

sentry-javascript/scripts/ci-unit-tests.ts

Line 32 in 5dd37a6

const SKIP_NODE_24_PACKAGES = ['@sentry/google-cloud-serverless'];

@AbhiPrasad
Copy link
Member Author

This was because of a Node 24 breaking change https://github.com/nodejs/node/releases/tag/v24.0.1 - we can remove this now.

@AbhiPrasad AbhiPrasad mentioned this issue May 9, 2025
Merged
mydea pushed a commit that referenced this issue May 9, 2025
@AbhiPrasad
chore(ci): re-enable Node 24 tests for google-cloud-serverless (#16242)
b3242e0 
resolves #16238

The error with the google cloud serverless tests in Node 24 was only
happening in Node `24.0.0`, which was fixed in
[`24.0.1`](https://github.com/nodejs/node/releases/tag/v24.0.1), so we
can safely re-enable everything.
@AbhiPrasad AbhiPrasad mentioned this issue May 9, 2025
Merged
andreiborza pushed a commit that referenced this issue May 9, 2025
@AbhiPrasad
build: Pin node unit tests to ^24.0.1 (#16248)
8f7599a 
Node [`24.0.1`](https://github.com/nodejs/node/releases/tag/v24.0.1)
fixed a bug with our google cloud serverless tests that we were running
into in #16238

For some reason CI doesn't want to use it? So pinning to `^24.0.1`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): re-enable Node 24 tests for google-cloud-serverless getsentry/sentry-javascript
1 participant
@AbhiPrasad