Skip to content

Implement sendDefaultPii behaviour in the JS SDKs #5347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lms24 opened this issue Jul 1, 2022 · 7 comments
Closed

Implement sendDefaultPii behaviour in the JS SDKs #5347

Lms24 opened this issue Jul 1, 2022 · 7 comments

Comments

@Lms24
Copy link
Member

Lms24 commented Jul 1, 2022

Extracted from #5340

This issue tracks the second step of adding the sendDefaultPii SDK init option to the JS SDK. Currently, the flag is only used to avoid sensitive data being propagated in distributed tracing via the dynamic sampling context. In v8, we'll add the additional behaviour of this flag as described in the Sentry SDK development specification

@Lms24 Lms24 changed the title In v8 of the JS SDK, we'll add the additional behaviour, as defined in the spec. Implement sendDefaultPii behaviour in the JS SDKs Jul 1, 2022
@Lms24 Lms24 added this to the 8.0.0 milestone Jul 1, 2022
@HazAT
Copy link
Member

HazAT commented Jan 26, 2023

Linking getsentry/rfcs#62

@HazAT
Copy link
Member

HazAT commented Feb 16, 2023

Related: #4777

@HazAT
Copy link
Member

HazAT commented Feb 16, 2023

Related: #6389

@mydea
Copy link
Member

mydea commented Jan 20, 2025

So some notes for this:

  1. In browser, we want to guard adding the {{auto}} value in all the places introduced here: feat(browser): Set user.ip_address explicitly to {{auto}} #15008 to only be set when sendDefaultPii: true is configured.
  2. In node, we need to decide - currently, the ip address is opt-in by passing requestDataIntegration({ ip: true }). We may want to instead guard this based on sendDefaultPii too. Possibly, the logic can be: const sendIpAddress = options.ip || clientOptions.sendDefaultPii 🤔

@Lms24
Copy link
Member Author

Lms24 commented Jan 22, 2025

options.ip || clientOptions.sendDefaultPii

shouldn't this rather be options.ip ?? clientOptions.sendDefaultPii? Otherwise there's no way to opt out of IP collection granularly, right?

Copy link
Member

mydea commented Apr 14, 2025

I guess this issue is basically done now? We use the option for IP addresses on backend and frontend now, at least.

@Lms24
Copy link
Member Author

Lms24 commented Apr 14, 2025

yeah, it has been open for a long time and nothing really moved specifically for this issue but rather when things needed to move. Let's close it and continue using the flag on a case-by-case basis :)

@Lms24 Lms24 closed this as completed Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants