Skip to content

Commit 9ef5359

Browse files
committed
little optimize
1 parent 4064058 commit 9ef5359

File tree

1 file changed

+3
-24
lines changed

1 file changed

+3
-24
lines changed

src/esl.js

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -366,26 +366,8 @@ var esl;
366366
* @param {string} id 模块id
367367
*/
368368
function modAnalyse(id) {
369-
var requireModules = [];
370-
var requireModulesIndex = {};
371-
372-
/**
373-
* 添加需要请求的模块
374-
*
375-
* @inner
376-
* @param {string} id 模块id
377-
*/
378-
function addRequireModule(id) {
379-
if (modModules[id] || requireModulesIndex[id]) {
380-
return;
381-
}
382-
383-
requireModules.push(id);
384-
requireModulesIndex[id] = 1;
385-
}
386-
387369
var module = modModules[id];
388-
if (!module || module.state > MODULE_PRE_DEFINED) {
370+
if (!module || modIs(id, MODULE_ANALYZED)) {
389371
return;
390372
}
391373

@@ -409,6 +391,7 @@ var esl;
409391
);
410392
}
411393

394+
var requireModules = [];
412395
each(deps, function (depId, index) {
413396
var idInfo = parseId(depId);
414397
var absId = normalize(idInfo.module, id);
@@ -449,7 +432,7 @@ var esl;
449432
};
450433
module.depMs.push(moduleInfo);
451434
module.depMkv[absId] = moduleInfo;
452-
addRequireModule(absId);
435+
requireModules.push(absId);
453436
}
454437
}
455438
else {
@@ -465,10 +448,6 @@ var esl;
465448
});
466449

467450
module.state = MODULE_ANALYZED;
468-
each(module.depMs, function (dep) {
469-
modAnalyse(dep.absId);
470-
});
471-
472451
modInitFactoryInvoker(id);
473452
nativeRequire(requireModules);
474453
}

0 commit comments

Comments
 (0)