Wrong build order of arguments and options?

[vitorbrandao]

Executing repo.git.stash('save', keep_index=True) turns into:

git.exc.GitCommandError: 'git stash --keep-index save' returned exit status 1: Usage: git stash list [<options>]
   or: git stash show [<stash>]
   or: git stash drop [-q|--quiet] [<stash>]
   or: git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]
   or: git stash branch <branchname> [<stash>]
   or: git stash [save [--patch] [-k|--[no-]keep-index] [-q|--quiet]
                       [-u|--include-untracked] [-a|--all] [<message>]]
   or: git stash clear

The command built by GitPython is git stash --keep-index save.

If using git stash save --keep-index (options first) then this works fine. Thoughts?

[Byron]

Unfortunately I don't believe this is easy to fix, as the order it uses seems to work for most other commands, whereas a different order doesn't.

However, this was defined with older versions of git, and I remember that I have chosen this particular order on purpose.
Maybe one could fix it by adding a specially recognized flag that will change the order of arguments.

[vitorbrandao]

You're right. This is an exception to other git commands. Your suggestion of a flag might work just fine. I'll try to send a PR if I find some free time. Thanks for the reply and thanks for this awesome project!

[vitorbrandao]

How do you build this command git remote update --prune origin? Note prune must be placed after update.

[Byron]

I don't think it can be build with the current engine, there needs to be a way to reverse the order.

[millerdev]

Here's a workaround:

repo.git.stash('save', '--keep-index')
repo.git.remote('update', '--prune', 'origin')
repo.git.remote('add', '--mirror=fetch', 'origin', url)

[Byron]

I confirm that the only way to control order is to use the string arguments form to invoke the git command, as it will maintain the given ordering of arguments.
This is a suitable workaround for the issue stated here.
Thanks for bringing this up, @millerdev .