Skip to content

Symbolic refs don't parse correctly when a comment appears in the ref file. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gregbean opened this issue Oct 18, 2012 · 3 comments
Closed

Comments

@gregbean
Copy link

When fetching a ref from a remote server, the ref file can contain a comment, like:

The file FETCH_HEAD:

ecc2505c5d373f8384477cc4d831bbd9323d061c 'refs/my/stuff' of git://my.git/my/repo.git

Because this comment is prefixed with two tabs, it breaks the value.split() call in SymbolicReference._get_ref_info().

@Byron
Copy link
Member

Byron commented Oct 18, 2012

Thanks for bringing this up! I have had cases where a fetch result was not correctly understood as well, and it seems one really wants to use regex here instead of parsing it manually.
Parsing needs to be more robust here and in some other cases.

@Byron Byron added this to the v0.3.5 - bugfixes milestone Nov 19, 2014
@Byron
Copy link
Member

Byron commented Nov 19, 2014

It would be great to have a FETCH_HEAD example with an actual comment in it.
FETCH information parsing was improved a lot, and I wonder if this is still an issue.
Maybe you can provide more information helping to reproduce this, until I start working on 0.3.5.
Thank you.

@Byron
Copy link
Member

Byron commented Jan 7, 2015

As I am unable to reproduce this issue, I will close it, also referring to the large amount of changes that were introduced in the meanwhile.
If there is still an issue of this kind in the latest release, please file it.

@Byron Byron closed this as completed Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants