Skip to content

test_region fails on powerpc #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue May 5, 2015 · 3 comments
Closed

test_region fails on powerpc #25

ghost opened this issue May 5, 2015 · 3 comments

Comments

@ghost
Copy link

ghost commented May 5, 2015

The following assert found in smmap/test/test_util.py fails on a powerpc64 system running linux and python 2.7.9:

assert rhalfofs.includes_ofs(rofs) and not rhalfofs.includes_ofs(0)

This test probably fails on other non-x86 platforms. And I am not sure it is really meaningful since it is highly dependent on the underlying OS and platform.

@Byron
Copy link
Member

Byron commented May 6, 2015

As this issue only appears in the test-suite, I guess it would be safe to just exclude the said line for power-pc architectures as well, similar to how it's done with win32.
Unfortunately I don't really know how to identify such a platform, as I am lacking the hardware. Maybe you can cookup a PR or let me know the values of sys.platform and os.name ?

@ghost
Copy link
Author

ghost commented May 6, 2015

Sorry, I don't have access to real hardware either. I found the problem when updating the package on opensuse and I patched out the test as a workaround.

This assert does not really test the correctness of smmap but the implementation of mmap on the platform. So I suggest to remove it from the test-suite.

@Byron
Copy link
Member

Byron commented May 6, 2015

Thank you, I will do that.

@Byron Byron closed this as completed in 18e4aea May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant