x/tools/gopls: find reference doesn't reported all references of usages

[xieyuschen]

gopls version

v0.18.1

go env

irrelevant

What did you do?

• Click Preorder of func (c Cursor) Preorder(types ...ast.Node) iter.Seq[Cursor] inside file $tools/go/ast/inspector/cursor.go.

• right client at Preorder, and then select Find All Reference.

What did you see happen?

$tools/gopls/internal/analysis/modernize/minmax.go has use this method inside for curIfStmt := range curFile.Preorder((*ast.IfStmt)(nil)) {. But gopls doesn't report this usage.

What did you expect to see?

I expected gopls reports its usage. I suspect it's the issue that the gopls isn't the same module of tools.

So the question might be: is it better to report references for submodules as well, if current project contains a root module and multiple modules? And is it possible to do so?

Editor and settings

No response

Logs

No response

[EXELANCE-LLC]

❤️

[gabyhelp]

Related Issues

• x/tools/gopls: support module-local references #32869 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}