Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grrtrr/aws-c-io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: grrtrr/aws-c-io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: windows-cert-improvements
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Mar 12, 2022

  1. improve errors when searching windows cert store 

    - Replace an AWS_FATAL_ASSERT() with actual error handling: User-inputted strings should not crash a program.
- Improved error logging: Quotes around paths. Describes how to fix problems with paths.
    @graebm
    graebm committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    c8d96ec View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Fix string matching of Windows Cert locations. 

    - Bug was how we used `strncpy()`. Any substring would look like a full string match. Ex: "Cu" would match "CurrentUser" because first 2 characters were same. Solution is to use our byte-cursor string matching functions.
- Also, move to using byte-cursor functions instead of strchr and pointer arithmetic. These functions weren't available when this code was first written.
    @graebm
    graebm committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    12fe019 View commit details
    Browse the repository at this point in the history
Loading