Skip to content

Commit 1a1ceb9

Browse files
davideastjeffbcross
authored andcommitted
chore(modules): Organize utils
1 parent 8723dbd commit 1a1ceb9

13 files changed

+37
-33
lines changed

src/angularfire2.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {
1919
FirebaseConfig,
2020
FirebaseApp,
2121
defaultFirebase,
22-
FirebaseDatabase,
22+
AngularFireDatabase,
2323
FirebaseAppConfig
2424
} from './angularfire2';
2525
import {Subscription} from 'rxjs';
@@ -78,7 +78,7 @@ describe('angularfire', () => {
7878

7979
describe('.database', () => {
8080
it('should be an instance of Database', inject([AngularFire], (af:AngularFire) => {
81-
expect(af.database).toBeAnInstanceOf(FirebaseDatabase);
81+
expect(af.database).toBeAnInstanceOf(AngularFireDatabase);
8282
}));
8383
});
8484

src/angularfire2.ts

+19-16
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,39 @@
11
import { initializeApp } from 'firebase';
2-
import * as utils from './utils/utils';
2+
import * as utils from './utils';
33
import { FirebaseAppConfig } from './interfaces';
4-
import {
5-
FirebaseListFactoryOpts,
4+
import {
5+
FirebaseListFactoryOpts,
66
FirebaseObjectFactoryOpts,
77
} from './interfaces';
88
import {
99
FirebaseConfig,
1010
FirebaseApp,
1111
WindowLocation
1212
} from './tokens';
13-
import {
14-
APP_INITIALIZER,
15-
Inject,
16-
Injectable,
17-
OpaqueToken,
18-
provide,
19-
Provider
13+
import {
14+
APP_INITIALIZER,
15+
Inject,
16+
Injectable,
17+
OpaqueToken,
18+
provide,
19+
Provider
2020
} from '@angular/core';
21-
import {
21+
import {
2222
FirebaseSdkAuthBackend,
23-
AngularFireAuth,
24-
firebaseAuthConfig,
23+
AngularFireAuth,
24+
firebaseAuthConfig,
2525
FirebaseAuth,
2626
AuthBackend,
2727
AuthMethods,
2828
AuthProviders,
29-
FirebaseAuthState
29+
FirebaseAuthState
3030
} from './auth/index';
3131
import {
3232
FirebaseListObservable,
3333
FirebaseObjectObservable,
3434
FirebaseListFactory,
3535
FirebaseObjectFactory,
36+
AngularFireDatabase,
3637
FirebaseDatabase
3738
} from './database/index';
3839

@@ -41,7 +42,7 @@ export class AngularFire {
4142
constructor(
4243
@Inject(FirebaseConfig) private fbUrl:string,
4344
public auth: AngularFireAuth,
44-
public database: FirebaseDatabase) {}
45+
public database: AngularFireDatabase) {}
4546
}
4647

4748
export const COMMON_PROVIDERS: any[] = [
@@ -56,7 +57,7 @@ export const COMMON_PROVIDERS: any[] = [
5657
},
5758
AngularFireAuth,
5859
AngularFire,
59-
FirebaseDatabase
60+
AngularFireDatabase,
6061
];
6162

6263
function _getFirebase(config: FirebaseAppConfig): firebase.app.App {
@@ -94,8 +95,10 @@ export const defaultFirebase = (config: FirebaseAppConfig): Provider => {
9495

9596
export {
9697
AngularFireAuth,
98+
AngularFireDatabase,
9799
// TODO: Deprecate
98100
FirebaseAuth,
101+
// TODO: Deprecate
99102
FirebaseDatabase,
100103
FirebaseListObservable,
101104
FirebaseObjectObservable,

src/auth/auth.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ import { Observable } from 'rxjs/Observable';
33
import { Observer } from 'rxjs/Observer';
44
import { ReplaySubject } from 'rxjs/ReplaySubject';
55
import { FirebaseApp, FirebaseAuthConfig, WindowLocation } from '../tokens';
6-
import { isPresent } from '../utils/utils';
7-
import * as utils from '../utils/utils';
6+
import * as utils from '../utils';
87
import {
98
authDataToAuthState,
109
AuthBackend,
@@ -84,12 +83,12 @@ export class AngularFireAuth extends ReplaySubject<FirebaseAuthState> {
8483
}
8584
config = this._mergeConfigs(config);
8685

87-
if (!isPresent(config.method)) {
86+
if (!utils.isPresent(config.method)) {
8887
return this._reject('You must provide a login method');
8988
}
9089
let providerMethods = [AuthMethods.Popup, AuthMethods.Redirect, AuthMethods.OAuthToken];
9190
if (providerMethods.indexOf(config.method) != -1) {
92-
if (!isPresent(config.provider)) {
91+
if (!utils.isPresent(config.provider)) {
9392
return this._reject('You must include a provider to use this auth method.');
9493
}
9594
}

src/auth/firebase_sdk_auth_backend.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Injectable, Inject } from '@angular/core';
22
import { Observable } from 'rxjs/Observable';
33
import { Observer } from 'rxjs/Observer';
44
import { FirebaseApp } from '../tokens';
5-
import { isPresent } from '../utils/utils';
5+
import { isPresent } from '../utils';
66
import { auth } from 'firebase';
77
import {
88
authDataToAuthState,

src/database/database.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@ import { FirebaseConfig } from '../tokens';
33
import { FirebaseAppConfig } from '../angularfire2';
44
import { FirebaseListFactory } from './index';
55
import { FirebaseListFactoryOpts, FirebaseObjectFactoryOpts } from '../interfaces';
6-
import * as utils from '../utils/utils';
6+
import * as utils from '../utils';
77
import {
88
FirebaseListObservable,
99
FirebaseObjectObservable,
1010
FirebaseObjectFactory
1111
} from './index';
1212

1313
@Injectable()
14-
export class FirebaseDatabase {
14+
export class AngularFireDatabase {
1515
constructor(@Inject(FirebaseConfig) private fbConfig:FirebaseAppConfig) {}
1616
list (urlOrRef:string | firebase.database.Reference, opts?:FirebaseListFactoryOpts):FirebaseListObservable<any[]> {
1717
return utils.checkForUrlOrFirebaseRef(urlOrRef, {
@@ -27,6 +27,9 @@ export class FirebaseDatabase {
2727
}
2828
}
2929

30+
// TODO: Deprecate
31+
export class FirebaseDatabase extends AngularFireDatabase {}
32+
3033
function getAbsUrl (root:FirebaseAppConfig, url:string) {
3134
if (!(/^[a-z]+:\/\/.*/.test(url))) {
3235
// Provided url is relative.

src/database/firebase_list_factory.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import {
2525
beforeEachProviders,
2626
inject
2727
} from '@angular/core/testing';
28-
import * as utils from '../utils/utils';
28+
import * as utils from '../utils';
2929
import {Query} from '../interfaces';
3030
import {Subscription, Observable, Subject} from 'rxjs';
3131
import 'rxjs/add/operator/do';

src/database/firebase_list_factory.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Observer } from 'rxjs/Observer';
44
import { database } from 'firebase';
55
import { observeQuery } from './query_observable';
66
import { Query, FirebaseListFactoryOpts } from '../interfaces';
7-
import * as utils from '../utils/utils';
7+
import * as utils from '../utils';
88
import 'rxjs/add/operator/mergeMap';
99
import 'rxjs/add/operator/map';
1010

src/database/firebase_list_observable.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Observer } from 'rxjs/Observer';
33
import { Observable } from 'rxjs/Observable';
44
import 'rxjs/add/operator/map';
55
import { database } from 'firebase';
6-
import { unwrapMapFn } from '../utils/utils';
6+
import { unwrapMapFn } from '../utils';
77
import {
88
FIREBASE_PROVIDERS,
99
defaultFirebase,

src/database/firebase_list_observable.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Observable } from 'rxjs/Observable';
22
import { Operator } from 'rxjs/Operator';
33
import { Subscriber } from 'rxjs/Subscriber';
44
import { Subscription } from 'rxjs/Subscription';
5-
import * as utils from '../utils/utils';
5+
import * as utils from '../utils';
66
import {
77
AFUnwrappedDataSnapshot,
88
FirebaseOperationCases

src/database/firebase_object_factory.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { FirebaseObjectObservable } from './index';
22
import { Observer } from 'rxjs/Observer';
33
import { database } from 'firebase';
4-
import * as utils from '../utils/utils';
4+
import * as utils from '../utils';
55
import { Query } from '../interfaces';
66
import { observeQuery } from './query_observable';
77
import { FirebaseObjectFactoryOpts } from '../interfaces';

src/utils/utils.ts renamed to src/utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { AFUnwrappedDataSnapshot} from '../interfaces';
1+
import { AFUnwrappedDataSnapshot} from './interfaces';
22

33
export function isPresent(obj: any): boolean {
44
return obj !== undefined && obj !== null;

src/utils/index.ts

-1
This file was deleted.

src/worker/auth/worker/auth.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
OAuth2Credentials,
2323
OAuthCredentials
2424
} from '../../auth_backend';
25-
import {isPresent} from '../../../utils/utils';
25+
import {isPresent} from '../../../utils';
2626
import * as firebase from 'firebase';
2727

2828
@Injectable()

0 commit comments

Comments
 (0)