Skip to content

Commit debc404

Browse files
Merge pull request derek-schaefer#11 from robthehall/master
Make (en|de)coder_kwargs optional
2 parents 4869de9 + 4eaa0ea commit debc404

File tree

3 files changed

+15
-2
lines changed

3 files changed

+15
-2
lines changed

json_field/forms.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ class JSONFormField(fields.Field):
88

99
def __init__(self, *args, **kwargs):
1010
self.simple = kwargs.pop('simple', False)
11-
self.encoder_kwargs = kwargs.pop('encoder_kwargs')
12-
self.decoder_kwargs = kwargs.pop('decoder_kwargs')
11+
self.encoder_kwargs = kwargs.pop('encoder_kwargs', {})
12+
self.decoder_kwargs = kwargs.pop('decoder_kwargs', {})
1313
super(JSONFormField, self).__init__(*args, **kwargs)
1414

1515
def clean(self, value):

test_project/app/forms.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
from json_field.forms import JSONFormField
2+
3+
from django.forms import Form
4+
5+
class TestForm(Form):
6+
json = JSONFormField()

test_project/app/tests.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from test_project.app.models import Test
2+
from test_project.app.forms import TestForm
23

34
from django.test import TestCase
45
from django.db.utils import IntegrityError
@@ -100,3 +101,9 @@ def test_strings(self):
100101
t4 = Test.objects.create(json='"a')
101102
self.assertEqual('"a', t4.json)
102103
self.assertEqual('"\\"a"', t4.get_json_json())
104+
105+
def test_formfield(self):
106+
data = {'json': '{}'}
107+
f1 = TestForm(data)
108+
self.assertTrue(f1.is_valid())
109+
self.assertEqual(f1.cleaned_data, data)

0 commit comments

Comments
 (0)