Skip to content

Commit 2767860

Browse files
authored
Merge pull request zostera#406 from mkoistinen/feature/errors_type_support
Satisfies zostera#380: Adds ‘errors_types’ support in bootstrap_form tag
2 parents 66ca85f + 33bc62f commit 2767860

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

AUTHORS.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ Contributors
2222
* Jordan Starcher <[email protected]>
2323
* Juan Carlos <[email protected]>
2424
* Markus Holtermann <[email protected]>
25+
* Martin Koistinen <[email protected]>
2526
2627
* Owais Lone <[email protected]>
2728

HISTORY.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Development (in progress)
88
+++++++++++++++++++++++++
99

1010
* Renamed requirements-dev.txt back to requirements.txt because that suits ReadTheDocs better
11+
* Added 'errors_type' support on bootstrap3_form (thanks @mkoistinen)
1112

1213

1314
8.2.3 (2017-05-05)

bootstrap3/renderers.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ def __init__(self, form, *args, **kwargs):
166166
if DBS3_SET_REQUIRED_SET_DISABLED and self.form.empty_permitted:
167167
self.set_required = False
168168

169+
self.errors_type = kwargs.get('errors_type', 'all')
169170
self.error_css_class = kwargs.get('error_css_class', None)
170171
self.required_css_class = kwargs.get('required_css_class', None)
171172
self.bound_css_class = kwargs.get('bound_css_class', None)
@@ -202,7 +203,7 @@ def get_fields_errors(self):
202203
return form_errors
203204

204205
def render_errors(self, type='all'):
205-
form_errors = None
206+
form_errors = []
206207
if type == 'all':
207208
form_errors = self.get_fields_errors() + self.form.non_field_errors()
208209
elif type == 'fields':
@@ -224,7 +225,7 @@ def render_errors(self, type='all'):
224225
return ''
225226

226227
def _render(self):
227-
return self.render_errors() + self.render_fields()
228+
return self.render_errors(self.errors_type) + self.render_fields()
228229

229230

230231
class FieldRenderer(BaseRenderer):

bootstrap3/templatetags/bootstrap3.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,13 @@ def bootstrap_form(*args, **kwargs):
318318
A list of field names (comma separated) that should not be rendered
319319
E.g. exclude=subject,bcc
320320
321+
errors_type
322+
This controls the types of errors that are rendered above the form.
323+
Choices are: "all", "fields", "non_fields" or "none". This will not
324+
affect the display of errors on the fields themselves.
325+
326+
Default is "all".
327+
321328
See bootstrap_field_ for other arguments
322329
323330
**Usage**::

0 commit comments

Comments
 (0)