Skip to content

Commit d9831f2

Browse files
committed
fix new version being unbound and replace new lines
1 parent 6430396 commit d9831f2

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/rechunk/utils.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ def get_labels(
151151
prev_labels = prev_manifest.get("Labels", {}) if prev_manifest else {}
152152
prev_version = prev_labels.get(VERSION_TAG, None) if prev_labels else None
153153
prev_versions = prev_manifest.get("RepoTags", []) if prev_manifest else []
154+
new_version = None
154155

155156
new_labels = {}
156157
if version:
@@ -175,7 +176,7 @@ def get_labels(
175176
logger.info(f"Previous version: '{prev_version}'")
176177

177178
# Write version to file
178-
if version_fn:
179+
if version_fn and new_version:
179180
with open(version_fn, "w") as f:
180181
f.write(new_version)
181182

@@ -205,6 +206,11 @@ def get_labels(
205206
vkey = f"<version:{pkg.name}>"
206207
if vkey in value:
207208
value = value.replace(vkey, pkg.version)
209+
210+
# OCI spec does not like new lines
211+
value = value.replace('\n', '\\n')
212+
value = value.replace('\r', '\\r')
213+
208214
new_labels[key] = value
209215

210216
if new_labels:

0 commit comments

Comments
 (0)