Complete private members from libraries in Evaluate Expression dialog

Author: NataliaUkhorskaya

Changelog.md

@@ -23,3 +23,4 @@
 ### IDE
 - Debugger can distinguish nested inline arguments
 - Add kotlinClassName() and kotlinFunctionName() macros for use in live templates
+- Complete private members from libraries in Evaluate Expression dialog

idea/idea-completion/src/org/jetbrains/kotlin/idea/completion/CompletionSession.kt

@@ -191,7 +191,7 @@ abstract class CompletionSession(
         if (descriptor is DeclarationDescriptorWithVisibility) {
             val visible = descriptor.isVisible(position, callTypeAndReceiver.receiver as? KtExpression, bindingContext, resolutionFacade)
             if (visible) return true
-            return completeNonAccessible && !descriptor.isFromLibrary()
+            return completeNonAccessible && (!descriptor.isFromLibrary() || file is KtCodeFragment)
         }
 
         return true

idea/idea-completion/testData/basic/codeFragments/privatesInSecondPressCompletion.kt

@@ -0,0 +1,13 @@
+import java.io.File
+
+class MyFile : File("file") {
+    private val privateField = 0
+}
+
+fun foo(f: MyFile) {
+    val a = 1<caret>
+}
+
+// INVOCATION_COUNT: 2
+// EXIST: privateField
+// EXIST: prefixLength

idea/idea-completion/testData/basic/codeFragments/privatesInSecondPressCompletion.kt.fragment

@@ -0,0 +1 @@
+f.<caret>

idea/tests/org/jetbrains/kotlin/idea/debugger/evaluate/CodeFragmentCompletionTestGenerated.java

@@ -83,6 +83,12 @@ public void testNoDuplicatesForSyntheticProperties() throws Exception {
         doTest(fileName);
     }
 
+    @TestMetadata("privatesInSecondPressCompletion.kt")
+    public void testPrivatesInSecondPressCompletion() throws Exception {
+        String fileName = KotlinTestUtils.navigationMetadata("idea/idea-completion/testData/basic/codeFragments/privatesInSecondPressCompletion.kt");
+        doTest(fileName);
+    }
+
     @TestMetadata("topLevel.kt")
     public void testTopLevel() throws Exception {
         String fileName = KotlinTestUtils.navigationMetadata("idea/idea-completion/testData/basic/codeFragments/topLevel.kt");