Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iCamilo/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: husamdev/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 9 files changed
  • 3 contributors

Commits on Sep 21, 2020

  1. Update to recommended settings (Xcode 12)

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    61f0cd5 View commit details
    Browse the repository at this point in the history

  2. Replace #file with the new #filePath

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f00d440 View commit details
    Browse the repository at this point in the history

  3. Update CI config to use Xcode 12

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    9bdb08b View commit details
    Browse the repository at this point in the history

  4. Update README

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    ac0f5c1 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #35 from essentialdevelopercom/xcode12 

    Update to Xcode 12
    @mapostolakis
    mapostolakis authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    a8ca4b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. Fix indentation

    @caiozullo
    caiozullo committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    7df577c View commit details
    Browse the repository at this point in the history

  2. Update CI config to run with Xcode 12.2

    @caiozullo
    caiozullo committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    a0682f1 View commit details
    Browse the repository at this point in the history

  3. Update README

    @caiozullo
    caiozullo committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    33b4783 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #77 from essentialdevelopercom/xcode12_2 

    Update to Xcode 12.2
    @mapostolakis
    mapostolakis authored Nov 27, 2020
    Configuration menu
    Copy the full SHA
    6712138 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. Trigger CI on push/pull_request

    @caiozullo
    caiozullo committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    65edf14 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2021

  1. Call client get method

    Husam committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    ba90322 View commit details
    Browse the repository at this point in the history

  2. Complete load method with connectivity failure when receiving client … 

    …error
    Husam committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    2c0b91a View commit details
    Browse the repository at this point in the history

  3. Complete with failure invalid data on success

    Husam committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    bfa0766 View commit details
    Browse the repository at this point in the history

  4. Complete with invalid data when json is invalid

    Husam committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    0b8d80e View commit details
    Browse the repository at this point in the history

  5. Complete with empty array when receiving empty json list

    Husam committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    8852f55 View commit details
    Browse the repository at this point in the history

  6. Complete with feed items when receiving json items

    Husam committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    07862e2 View commit details
    Browse the repository at this point in the history

  7. Refactored RemoteFeedLoader load method by creating FeedImageMapper

    Husam committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    4c96a41 View commit details
    Browse the repository at this point in the history

  8. Stop completion for the RemoteFeedLoader load method if the instanc… 

    …e is deallocated
    Husam committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    7a6f086 View commit details
    Browse the repository at this point in the history
Loading