Skip to content

Commit fa780ad

Browse files
authored
fix: removed misleading parameters (singerdmx#1825)
* fix: removed misleading parameters * unused imports
1 parent b547e28 commit fa780ad

File tree

14 files changed

+0
-43
lines changed

14 files changed

+0
-43
lines changed

flutter_quill_extensions/lib/embeds/image/toolbar/image_button.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ class QuillToolbarImageButton extends StatelessWidget {
8181
iconSize: iconSize,
8282
iconButtonFactor: iconButtonFactor,
8383
dialogTheme: options.dialogTheme,
84-
fillColor: options.fillColor,
8584
iconTheme: options.iconTheme,
8685
linkRegExp: options.linkRegExp,
8786
tooltip: options.tooltip,

flutter_quill_extensions/lib/embeds/others/camera_button/camera_button.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ class QuillToolbarCameraButton extends StatelessWidget {
8787
QuillToolbarCameraButtonOptions(
8888
afterButtonPressed: _afterButtonPressed(context),
8989
iconData: options.iconData,
90-
fillColor: options.fillColor,
9190
iconSize: options.iconSize,
9291
iconButtonFactor: iconButtonFactor,
9392
iconTheme: options.iconTheme,

flutter_quill_extensions/lib/models/config/camera/camera_configurations.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'package:flutter/widgets.dart' show Color;
21
import 'package:flutter_quill/flutter_quill.dart';
32

43
import '../../../embeds/others/camera_button/camera_types.dart';
@@ -18,15 +17,12 @@ class QuillToolbarCameraButtonOptions extends QuillToolbarBaseButtonOptions<
1817
this.cameraConfigurations = const QuillToolbarCameraConfigurations(),
1918
super.iconSize,
2019
super.iconButtonFactor,
21-
this.fillColor,
2220
super.iconData,
2321
super.afterButtonPressed,
2422
super.tooltip,
2523
super.iconTheme,
2624
super.childBuilder,
2725
});
2826

29-
final Color? fillColor;
30-
3127
final QuillToolbarCameraConfigurations cameraConfigurations;
3228
}

flutter_quill_extensions/lib/models/config/formula/formula_configurations.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'package:flutter/widgets.dart' show Color;
21
import 'package:flutter_quill/flutter_quill.dart';
32

43
class QuillToolbarFormulaButtonExtraOptions
@@ -18,10 +17,7 @@ class QuillToolbarFormulaButtonOptions extends QuillToolbarBaseButtonOptions<
1817
super.iconTheme,
1918
super.afterButtonPressed,
2019
super.childBuilder,
21-
this.fillColor,
2220
super.iconSize,
2321
super.iconButtonFactor,
2422
});
25-
26-
final Color? fillColor;
2723
}

flutter_quill_extensions/lib/models/config/image/toolbar/image_configurations.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'package:flutter/widgets.dart' show Color;
21
import 'package:flutter_quill/flutter_quill.dart';
32
import 'package:meta/meta.dart' show immutable;
43

@@ -26,14 +25,11 @@ class QuillToolbarImageButtonOptions extends QuillToolbarBaseButtonOptions<
2625
super.afterButtonPressed,
2726
super.childBuilder,
2827
super.iconTheme,
29-
this.fillColor,
3028
this.dialogTheme,
3129
this.linkRegExp,
3230
this.imageButtonConfigurations = const QuillToolbarImageConfigurations(),
3331
});
3432

35-
final Color? fillColor;
36-
3733
final QuillDialogTheme? dialogTheme;
3834

3935
/// [imageLinkRegExp] is a regular expression to identify image links.

flutter_quill_extensions/lib/models/config/media/media_button_configurations.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ class QuillToolbarMediaButtonOptions extends QuillToolbarBaseButtonOptions<
2424
this.childrenSpacing = 16.0,
2525
this.autovalidateMode = AutovalidateMode.disabled,
2626
super.iconSize,
27-
this.fillColor,
2827
this.dialogTheme,
2928
this.labelText,
3029
this.hintText,
@@ -40,7 +39,6 @@ class QuillToolbarMediaButtonOptions extends QuillToolbarBaseButtonOptions<
4039
super.childBuilder,
4140
});
4241

43-
final Color? fillColor;
4442
final QuillMediaType type;
4543
final QuillDialogTheme? dialogTheme;
4644
final MediaFilePicker? mediaFilePicker;

flutter_quill_extensions/lib/models/config/video/toolbar/video_configurations.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'package:flutter/widgets.dart' show Color;
21
import 'package:flutter_quill/flutter_quill.dart';
32

43
import '../../../../embeds/video/video.dart';
@@ -17,7 +16,6 @@ class QuillToolbarVideoButtonOptions extends QuillToolbarBaseButtonOptions<
1716
const QuillToolbarVideoButtonOptions({
1817
this.linkRegExp,
1918
this.dialogTheme,
20-
this.fillColor,
2119
super.iconSize,
2220
super.iconButtonFactor,
2321
super.iconData,
@@ -31,6 +29,4 @@ class QuillToolbarVideoButtonOptions extends QuillToolbarBaseButtonOptions<
3129
final RegExp? linkRegExp;
3230
final QuillDialogTheme? dialogTheme;
3331
final QuillToolbarVideoConfigurations videoConfigurations;
34-
35-
final Color? fillColor;
3632
}

lib/src/models/config/toolbar/buttons/font_size_configurations.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ class QuillToolbarFontSizeButtonOptions extends QuillToolbarBaseButtonOptions<
7575
QuillToolbarFontSizeButtonOptions copyWith({
7676
double? iconSize,
7777
double? iconButtonFactor,
78-
Color? fillColor,
7978
double? hoverElevation,
8079
double? highlightElevation,
8180
List<PopupMenuEntry<String>>? items,

lib/src/models/config/toolbar/buttons/search_configurations.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ class QuillToolbarSearchButtonOptions extends QuillToolbarBaseButtonOptions<
2323
super.iconSize,
2424
super.iconButtonFactor,
2525
this.dialogBarrierColor,
26-
this.fillColor,
2726
this.customOnPressedCallback,
2827
});
2928

@@ -32,8 +31,6 @@ class QuillToolbarSearchButtonOptions extends QuillToolbarBaseButtonOptions<
3231
/// By default will be [dialogBarrierColor] from [QuillSharedConfigurations]
3332
final Color? dialogBarrierColor;
3433

35-
final Color? fillColor;
36-
3734
/// By default we will show simple search dialog ui
3835
/// you can pass value to this callback to change this
3936
final QuillToolbarSearchButtonOnPressedCallback? customOnPressedCallback;

lib/src/models/config/toolbar/buttons/toggle_check_list_configurations.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'package:flutter/foundation.dart' show immutable;
2-
import 'package:flutter/widgets.dart' show Color;
32

43
import '../../../documents/attribute.dart';
54
import '../../quill_configurations.dart';
@@ -23,7 +22,6 @@ class QuillToolbarToggleCheckListButtonOptions
2322
const QuillToolbarToggleCheckListButtonOptions({
2423
super.iconSize,
2524
super.iconButtonFactor,
26-
this.fillColor,
2725
this.attribute = Attribute.unchecked,
2826
this.isShouldRequestKeyboard = false,
2927
super.iconTheme,
@@ -33,8 +31,6 @@ class QuillToolbarToggleCheckListButtonOptions
3331
super.childBuilder,
3432
});
3533

36-
final Color? fillColor;
37-
3834
final Attribute attribute;
3935

4036
/// Should we request the keyboard when you press the toggle check list button

lib/src/models/config/toolbar/buttons/toggle_style_configurations.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// ignore_for_file: public_member_api_docs, sort_constructors_first
22
import 'package:flutter/foundation.dart' show immutable;
3-
import 'package:flutter/widgets.dart' show Color;
43

54
import '../base_button_configurations.dart';
65

@@ -26,12 +25,9 @@ class QuillToolbarToggleStyleButtonOptions
2625
super.iconData,
2726
super.iconSize,
2827
super.iconButtonFactor,
29-
this.fillColor,
3028
super.tooltip,
3129
super.afterButtonPressed,
3230
super.iconTheme,
3331
super.childBuilder,
3432
});
35-
36-
final Color? fillColor;
3733
}

lib/src/models/themes/quill_icon_theme.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,10 @@ import 'package:flutter/material.dart';
44
@immutable
55
class QuillIconTheme {
66
const QuillIconTheme({
7-
this.iconButtonSelectedStyle,
8-
this.iconButtonUnselectedStyle,
97
this.iconButtonSelectedData,
108
this.iconButtonUnselectedData,
119
});
1210

13-
@Deprecated('Please use iconButtonUnselectedData instead')
14-
final ButtonStyle? iconButtonUnselectedStyle;
15-
@Deprecated('Please use iconButtonSelectedData instead')
16-
final ButtonStyle? iconButtonSelectedStyle;
17-
1811
final IconButtonData? iconButtonUnselectedData;
1912
final IconButtonData? iconButtonSelectedData;
2013

lib/src/widgets/toolbar/buttons/toggle_check_list_button.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ class QuillToolbarToggleCheckListButtonState
146146
context,
147147
Attribute.unchecked,
148148
iconData,
149-
options.fillColor,
150149
_isToggled,
151150
_toggleAttribute,
152151
afterButtonPressed,

lib/src/widgets/toolbar/buttons/toggle_style_button.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ typedef ToggleStyleButtonBuilder = Widget Function(
1313
BuildContext context,
1414
Attribute attribute,
1515
IconData icon,
16-
Color? fillColor,
1716
bool? isToggled,
1817
VoidCallback? onPressed,
1918
VoidCallback? afterPressed, [
@@ -172,7 +171,6 @@ class QuillToolbarToggleStyleButtonState
172171
context,
173172
widget.attribute,
174173
iconData,
175-
options.fillColor,
176174
_isToggled,
177175
_toggleAttribute,
178176
afterButtonPressed,
@@ -231,7 +229,6 @@ Widget defaultToggleStyleButtonBuilder(
231229
BuildContext context,
232230
Attribute attribute,
233231
IconData icon,
234-
Color? fillColor,
235232
bool? isToggled,
236233
VoidCallback? onPressed,
237234
VoidCallback? afterPressed, [

0 commit comments

Comments
 (0)