Merge pull request #104 from hyperwallet/bug/PPPLMER-105096-php-v3-fix-doc-parse

PPPLMER-105096: (Bug Fix) v3  Addressing key accessing errors for non-existing keys

Author: hlahlou-pp-dev

src/Hyperwallet/Hyperwallet.php

@@ -91,11 +91,11 @@ public function __construct($username, $password, $programToken = null, $server
      * @return array
      */
     private function setDocumentAndReasonFromResponseHelper($bodyResponse) {
-        $documents = $bodyResponse["documents"];
-        if ($documents) {
+        if (array_key_exists("documents", $bodyResponse)) {
+            $documents = $bodyResponse["documents"];
             foreach ($documents as &$dVal) {
-                $reasons = $dVal["reasons"];
-                if ($reasons) {
+                if (array_key_exists("reasons", $dVal)) {
+                    $reasons = $dVal["reasons"];
                     foreach ($reasons as &$rVal) {
                         $rVal = new HyperwalletVerificationDocumentReason($rVal);
                     }

tests/Hyperwallet/Tests/HyperwalletTest.php

@@ -4081,6 +4081,26 @@ public static function UPLOAD_REASON_DATA() {
         );
     }
 
+    public static function UPLOAD_REASON_DATA_NO_REASON() {
+        return array(
+            'token' => 'tkn-12345',
+            "documents" => array( array(
+                "category" => "IDENTIFICATION",
+                "type" => "PASSPORT",
+                "country" => "ES",
+                "status" => "NEW",
+                "createdOn" => "2020-11-24T19:05:02"
+
+            ))
+        );
+    }
+
+    public static function UPLOAD_REASON_DATA_NO_DOC() {
+        return array(
+            'token' => 'tkn-12345',
+        );
+    }
+
     public function testuploadDocumentsForUser_withoutUserToken() {
         // Setup
         $client = new Hyperwallet('test-username', 'test-password');
@@ -4199,6 +4219,75 @@ public function testuploadDocumentsForUser_parseReasons() {
         \Phake::verify($apiClientMock)->putMultipartData('/rest/v3/users/{user-token}', array('user-token' => $userToken), $options);
     }
 
+    public function testuploadDocumentsForUser_parseNoReasons() {
+        // Setup
+        $client = new Hyperwallet('test-username', 'test-password');
+        $apiClientMock = $this->createAndInjectApiClientMock($client);
+        $userToken = "user-token";
+
+        $options = array(
+            'multipart' => [
+                [
+                    'name'     => 'data',
+                    'contents' => '{"documents":[{"type":"DRIVERS_LICENSE","country":"AL","category":"IDENTIFICATION"}]}'
+                ],
+                [
+                    'name'     => 'drivers_license_front',
+                    'contents' => fopen(__DIR__ . "/../../resources/license-front.png", "r")
+                ],
+                [
+                    'name'     => 'drivers_license_back',
+                    'contents' => fopen(__DIR__ . "/../../resources/license-back.png", 'r')
+                ]
+            ]
+        );
+
+        \Phake::when($apiClientMock)->putMultipartData('/rest/v3/users/{user-token}', array('user-token' => $userToken), $options)->thenReturn($this->UPLOAD_REASON_DATA_NO_REASON());
+        // Run test
+        $newUser = $client->uploadDocumentsForUser($userToken, $options);
+        $this->assertNotNull($newUser);
+        $this->assertNull($newUser->getProgramToken());
+        $this->assertEquals($this->UPLOAD_REASON_DATA_NO_REASON()["documents"][0]["type"], $newUser->documents->documents[0]->type);
+
+        // Validate mock
+        \Phake::verify($apiClientMock)->putMultipartData('/rest/v3/users/{user-token}', array('user-token' => $userToken), $options);
+    }
+
+    public function testuploadDocumentsForUser_parseNoDocument() {
+        // Setup
+        $client = new Hyperwallet('test-username', 'test-password');
+        $apiClientMock = $this->createAndInjectApiClientMock($client);
+        $userToken = "user-token";
+
+        $options = array(
+            'multipart' => [
+                [
+                    'name'     => 'data',
+                    'contents' => '{"documents":[{"type":"DRIVERS_LICENSE","country":"AL","category":"IDENTIFICATION"}]}'
+                ],
+                [
+                    'name'     => 'drivers_license_front',
+                    'contents' => fopen(__DIR__ . "/../../resources/license-front.png", "r")
+                ],
+                [
+                    'name'     => 'drivers_license_back',
+                    'contents' => fopen(__DIR__ . "/../../resources/license-back.png", 'r')
+                ]
+            ]
+        );
+
+        \Phake::when($apiClientMock)->putMultipartData('/rest/v3/users/{user-token}', array('user-token' => $userToken), $options)->thenReturn($this->UPLOAD_REASON_DATA_NO_DOC());
+
+        // Run test
+        $newUser = $client->uploadDocumentsForUser($userToken, $options);
+        $this->assertNotNull($newUser);
+        $this->assertNull($newUser->getProgramToken());
+        $this->assertEquals($this->UPLOAD_REASON_DATA_NO_DOC()["token"], $newUser->token);
+
+        // Validate mock
+        \Phake::verify($apiClientMock)->putMultipartData('/rest/v3/users/{user-token}', array('user-token' => $userToken), $options);
+    }
+
 
     //--------------------------------------
     // Venmo Accounts