remove dep "string"; closes watson-developer-cloud#502

Author: boneskull

lib/requestwrapper.js

@@ -20,7 +20,6 @@ const extend = require('extend');
 const request = require('request');
 const pkg = require('../package.json');
 const helper = require('./helper');
-const parseString = require('string');
 const readableStream = require('stream').PassThrough;
 const isBrowser = typeof window === 'object';
 
@@ -34,12 +33,10 @@ function parsePath(path, params) {
   if (!path || !params) {
     return path;
   }
-  const escapedParams = {};
-  Object.keys(params).forEach(function(value) {
-    escapedParams[value] = encodeURIComponent(params[value]);
-  });
-
-  return parseString(path).template(escapedParams, '{', '}').s;
+  return Object.keys(params).reduce((parsedPath, param) => {
+    const value = encodeURIComponent(params[param]);
+    return parsedPath.replace(new RegExp(`{${param}}`), value);
+  }, path);
 }
 
 /**

package-lock.json

@@ -96,7 +96,6 @@
     "object.pick": "~1.3.0",
     "request": "~2.81.0",
     "solr-client": "^0.7.0",
-    "string": "3.3.3",
     "vcap_services": "~0.3.0",
     "websocket": "~1.0.22"
   },