Skip to content

Commit c3b58b3

Browse files
Changed .is() to .hasClass() where possible for performance.
1 parent faed3f9 commit c3b58b3

File tree

10 files changed

+15
-15
lines changed

10 files changed

+15
-15
lines changed

js/jquery.mobile.navigation.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ define( [
842842
if ( active.url &&
843843
active.url.indexOf( dialogHashKey ) > -1 &&
844844
$.mobile.activePage &&
845-
!$.mobile.activePage.is( ".ui-dialog" ) &&
845+
!$.mobile.activePage.hasClass( "ui-dialog" ) &&
846846
urlHistory.activeIndex > 0 ) {
847847
settings.changeHash = false;
848848
alreadyThere = true;
@@ -1280,7 +1280,7 @@ define( [
12801280

12811281
// If current active page is not a dialog skip the dialog and continue
12821282
// in the same direction
1283-
if ( $.mobile.activePage && !$.mobile.activePage.is( ".ui-dialog" ) ) {
1283+
if ( $.mobile.activePage && !$.mobile.activePage.hasClass( "ui-dialog" ) ) {
12841284
//determine if we're heading forward or backward and continue accordingly past
12851285
//the current dialog
12861286
if( data.direction === "back" ) {

js/widgets/collapsible.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ $.widget( "mobile.collapsible", $.mobile.widget, {
147147
})
148148
.bind( "click", function( event ) {
149149

150-
var type = collapsibleHeading.is( ".ui-collapsible-heading-collapsed" ) ? "expand" : "collapse";
150+
var type = collapsibleHeading.hasClass( "ui-collapsible-heading-collapsed" ) ? "expand" : "collapse";
151151

152152
collapsible.trigger( type );
153153

js/widgets/fixedToolbar.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ define( [ "jquery", "../jquery.mobile.widget", "../jquery.mobile.core", "../jque
7575
if ( tclass && tclass !== "none" ) {
7676
// use appropriate slide for header or footer
7777
if ( tclass === "slide" ) {
78-
tclass = this.element.is( ".ui-header" ) ? "slidedown" : "slideup";
78+
tclass = this.element.hasClass( "ui-header" ) ? "slidedown" : "slideup";
7979
}
8080

8181
this.element.addClass( tclass );
@@ -153,7 +153,7 @@ define( [ "jquery", "../jquery.mobile.widget", "../jquery.mobile.core", "../jque
153153
// This will set the content element's top or bottom padding equal to the toolbar's height
154154
updatePagePadding: function( tbPage ) {
155155
var $el = this.element,
156-
header = $el.is( ".ui-header" ),
156+
header = $el.hasClass( "ui-header" ),
157157
pos = parseFloat( $el.css( header ? "top" : "bottom" ) );
158158

159159
// This behavior only applies to "fixed", not "fullscreen"
@@ -260,7 +260,7 @@ define( [ "jquery", "../jquery.mobile.widget", "../jquery.mobile.core", "../jque
260260

261261
_destroy: function() {
262262
var $el = this.element,
263-
header = $el.is( ".ui-header" );
263+
header = $el.hasClass( "ui-header" );
264264

265265
$el.closest( ".ui-page" ).css( "padding-" + ( header ? "top" : "bottom" ), "" );
266266
$el.removeClass( "ui-header-fixed ui-footer-fixed ui-header-fullscreen ui-footer-fullscreen in out fade slidedown slideup ui-fixed-hidden" );

js/widgets/fixedToolbar.workarounds.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ define( [ "jquery", "../jquery.mobile.widget", "../jquery.mobile.core", "../jque
4646
//Utility class for checking header and footer positions relative to viewport
4747
_viewportOffset: function() {
4848
var $el = this.element,
49-
header = $el.is( ".ui-header" ),
49+
header = $el.hasClass( "ui-header" ),
5050
offset = Math.abs($el.offset().top - $.mobile.window.scrollTop());
5151
if( !header ) {
5252
offset = Math.round(offset - $.mobile.window.height() + $el.outerHeight())-60;

js/widgets/forms/checkboxradio.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ $.widget( "mobile.checkboxradio", $.mobile.widget, {
7373

7474
label.bind({
7575
vmouseover: function( event ) {
76-
if ( $( this ).parent().is( ".ui-disabled" ) ) {
76+
if ( $( this ).parent().hasClass( "ui-disabled" ) ) {
7777
event.stopPropagation();
7878
}
7979
},

js/widgets/forms/select.custom.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ define( [
196196
case 38:
197197
prev = li.prev().not( ".ui-selectmenu-placeholder" );
198198

199-
if ( prev.is( ".ui-li-divider" ) ) {
199+
if ( prev.hasClass( "ui-li-divider" ) ) {
200200
prev = prev.prev();
201201
}
202202

@@ -214,7 +214,7 @@ define( [
214214
case 40:
215215
next = li.next();
216216

217-
if ( next.is( ".ui-li-divider" ) ) {
217+
if ( next.hasClass( "ui-li-divider" ) ) {
218218
next = next.next();
219219
}
220220

@@ -319,7 +319,7 @@ define( [
319319
if ( self.isMultiple ) {
320320
item.find( ".ui-icon" ).removeClass( "ui-icon-checkbox-off" ).addClass( "ui-icon-checkbox-on" );
321321
} else {
322-
if ( item.is( ".ui-selectmenu-placeholder" ) ) {
322+
if ( item.hasClass( "ui-selectmenu-placeholder" ) ) {
323323
item.next().addClass( $.mobile.activeBtnClass );
324324
} else {
325325
item.addClass( $.mobile.activeBtnClass );

js/widgets/forms/select.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ $.widget( "mobile.selectmenu", $.mobile.widget, {
8080
var wrapper = this.element.parents( ".ui-select" );
8181
if ( wrapper.length > 0 ) {
8282
if ( wrapper.is( ".ui-btn-left, .ui-btn-right" ) ) {
83-
this.element.addClass( wrapper.is( ".ui-btn-left" ) ? "ui-btn-left" : "ui-btn-right" );
83+
this.element.addClass( wrapper.hasClass( "ui-btn-left" ) ? "ui-btn-left" : "ui-btn-right" );
8484
}
8585
this.element.insertAfter( wrapper );
8686
wrapper.remove();

js/widgets/forms/slider.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ $.widget( "mobile.slider", $.mobile.widget, {
466466
bPercent = percent === 100 ? 0 : Math.min( handlePercent + 100 - aPercent, 100 );
467467

468468
this._labels.each(function() {
469-
var ab = $( this ).is( ".ui-slider-label-a" );
469+
var ab = $( this ).hasClass( "ui-slider-label-a" );
470470
$( this ).width( ( ab ? aPercent : bPercent ) + "%" );
471471
});
472472
}

js/widgets/listview.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ $.widget( "mobile.listview", $.mobile.widget, {
9191
img = $( this._findFirstElementByTagName( containers[ i ].firstChild, "nextSibling", "img", "IMG" ) );
9292
if ( img.length ) {
9393
img.addClass( "ui-li-thumb" );
94-
$( this._findFirstElementByTagName( img[ 0 ].parentNode, "parentNode", "li", "LI" ) ).addClass( img.is( ".ui-li-icon" ) ? "ui-li-has-icon" : "ui-li-has-thumb" );
94+
$( this._findFirstElementByTagName( img[ 0 ].parentNode, "parentNode", "li", "LI" ) ).addClass( img.hasClass( "ui-li-icon" ) ? "ui-li-has-icon" : "ui-li-has-thumb" );
9595
}
9696
}
9797
},

js/widgets/popup.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,7 @@ define( [
825825
urlHistory = $.mobile.urlHistory;
826826
hashkey = $.mobile.dialogHashKey;
827827
activePage = $.mobile.activePage;
828-
currentIsDialog = activePage.is( ".ui-dialog" );
828+
currentIsDialog = activePage.hasClass( "ui-dialog" );
829829
this._myUrl = url = urlHistory.getActive().url;
830830
hasHash = ( url.indexOf( hashkey ) > -1 ) && !currentIsDialog && ( urlHistory.activeIndex > 0 );
831831

0 commit comments

Comments
 (0)