Bug: `search_history` and `command history` truncate wide entries

[aidancz]

RTFM Checklist

• I have searched exisiting issues / discussions
• I have read the Wiki including the Advanced section
• I have read man fzf / I am well versed in shell fzf

Operating system

linux

Shell

zsh

Neovim version (nvim --version)

NVIM v0.12.0-dev-630+g8af2aea24f

Fzf version (fzf --version)

0.62.0 (d226d841)

Output of :lua print(os.getenv('FZF_DEFAULT_OPTS'))

--color=16 --color=fg:-1 --color=fg+:-1:reverse --color=bg:-1 --color=bg+:-1:reverse --color=gutter:-1 --color=hl:4 --color=hl+:4:reverse --color=query:-1 --color=info:-1 --color=border:-1 --color=label:-1 --color=prompt:-1 --color=pointer:-1 --color=marker:-1 --color=spinner:-1 --color=header:-1 --bind=ctrl-a:first --bind=ctrl-e:last --no-unicode --pointer= --scrollbar= --highlight-line --scroll-off=0 --walker=file,dir,follow,hidden

Is the problem reproducible with mini.sh?

• My issue is reproducible with mini.sh
• My issue IS NOT reproducible with mini.sh
• I have not tested with mini.sh (not relevant, requires LSP, Windows, etc)

Fzf-lua configuration

require('fzf-lua').setup({
})

Describe the bug / steps to reproduce

search a string wider than vim.o.columns, run :FzfLua search_history

for example:

1. set columns=80
2. press /aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<cr>

the middle part is replaced by 3 dots

I recommend using vim.fn.histnr() and vim.fn.histget() instead of vim.fn.execute("history " .. str)

[phanen]

Maybe a hack is toggling vim.o.columns:
https://github.com/neovim/neovim/blob/2a7d0ed6145bf3f8b139c2694563f460f829813a/src/nvim/cmdhist.c#L667

But it make screen flicker, so better not do that.....

diff --git a/lua/fzf-lua/providers/nvim.lua b/lua/fzf-lua/providers/nvim.lua
index 8521e6d..08ee573 100644
--- a/lua/fzf-lua/providers/nvim.lua
+++ b/lua/fzf-lua/providers/nvim.lua
@@ -107,7 +107,10 @@ M.commands = function(opts)
 end
 
 local history = function(opts, str)
-  local history = vim.fn.execute("history " .. str)
+  local history
+  vim._with({ go = { columns = 1000 } }, function()
+    history = vim.fn.execute("history " .. str)
+  end)
   history = vim.split(history, "\n")
 
   local entries = {}

[phanen]

#2124.