Skip to content

Commit eb3b11b

Browse files
committed
Update tests
1 parent eadcbeb commit eb3b11b

File tree

3 files changed

+17
-36
lines changed

3 files changed

+17
-36
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@
5454
"@storybook/react-webpack5": "^8.4.7",
5555
"@storybook/test": "^8.4.7",
5656
"@testing-library/jest-dom": "^5.14.1",
57-
"@testing-library/react": "^12.0.0",
57+
"@testing-library/react": "^16.1.0",
5858
"@types/array.prototype.flatmap": "^1.2.2",
5959
"@types/node": "^16.7.10",
6060
"@types/react": "^18.0.0",
61+
"@types/react-dom": "^18.0.0",
6162
"@types/react-select": "^3.0.26",
6263
"@typescript-eslint/eslint-plugin": "^6.5.0",
6364
"@typescript-eslint/parser": "^6.5.0",

src/ActiveCell.test.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
*/
44

55
import * as React from "react";
6-
import { fireEvent, render } from "@testing-library/react";
6+
import { render, fireEvent } from "@testing-library/react";
77
import * as Point from "./point";
88
import * as Types from "./types";
99
import * as Actions from "./actions";
@@ -66,7 +66,7 @@ describe("<ActiveCell />", () => {
6666
const activeCell = document.querySelector(".Spreadsheet__active-cell");
6767
expect(activeCell).not.toBeNull();
6868
expect(activeCell).toHaveClass("Spreadsheet__active-cell--edit");
69-
expect(MOCK_DATA_EDITOR).toBeCalledTimes(1);
69+
expect(MOCK_DATA_EDITOR).toBeCalledTimes(2);
7070
expect(MOCK_DATA_EDITOR).toBeCalledWith(
7171
{
7272
row: Point.ORIGIN.row,
@@ -79,7 +79,7 @@ describe("<ActiveCell />", () => {
7979
);
8080
});
8181
test("calls setCellData if value changed", () => {
82-
const { rerender } = render(
82+
render(
8383
<context.Provider
8484
value={[{ ...STATE_WITH_ACTIVE, mode: "edit" }, DISPATCH_MOCK]}
8585
>
@@ -98,7 +98,7 @@ describe("<ActiveCell />", () => {
9898
value: "test",
9999
})
100100
);
101-
rerender(
101+
render(
102102
<context.Provider
103103
value={[{ ...STATE_WITH_ACTIVE, mode: "view" }, DISPATCH_MOCK]}
104104
>
@@ -108,7 +108,7 @@ describe("<ActiveCell />", () => {
108108
expect(activeCell).not.toHaveClass("Spreadsheet__active-cell--edit");
109109
});
110110
test("doesn't call setCellData if value not changed", () => {
111-
const { rerender } = render(
111+
render(
112112
<context.Provider
113113
value={[{ ...STATE_WITH_ACTIVE, mode: "edit" }, DISPATCH_MOCK]}
114114
>
@@ -118,7 +118,7 @@ describe("<ActiveCell />", () => {
118118
const activeCell = document.querySelector(".Spreadsheet__active-cell");
119119
expect(activeCell).not.toBeNull();
120120
expect(activeCell).toHaveClass("Spreadsheet__active-cell--edit");
121-
rerender(
121+
render(
122122
<context.Provider
123123
value={[{ ...STATE_WITH_ACTIVE, mode: "view" }, DISPATCH_MOCK]}
124124
>

yarn.lock

Lines changed: 9 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2393,20 +2393,6 @@
23932393
lz-string "^1.5.0"
23942394
pretty-format "^27.0.2"
23952395

2396-
"@testing-library/dom@^8.0.0":
2397-
version "8.5.0"
2398-
resolved "https://registry.yarnpkg.com/@testing-library/dom/-/dom-8.5.0.tgz#56e31331015f943a68c6ec27e259fdf16c69ab7d"
2399-
integrity sha512-O0fmHFaPlqaYCpa/cBL0cvroMridb9vZsMLacgIqrlxj+fd+bGF8UfAgwsLCHRF84KLBafWlm9CuOvxeNTlodw==
2400-
dependencies:
2401-
"@babel/code-frame" "^7.10.4"
2402-
"@babel/runtime" "^7.12.5"
2403-
"@types/aria-query" "^4.2.0"
2404-
aria-query "^4.2.2"
2405-
chalk "^4.1.0"
2406-
dom-accessibility-api "^0.5.6"
2407-
lz-string "^1.4.4"
2408-
pretty-format "^27.0.2"
2409-
24102396
"@testing-library/[email protected]":
24112397
version "6.5.0"
24122398
resolved "https://registry.yarnpkg.com/@testing-library/jest-dom/-/jest-dom-6.5.0.tgz#50484da3f80fb222a853479f618a9ce5c47bfe54"
@@ -2435,13 +2421,12 @@
24352421
lodash "^4.17.15"
24362422
redent "^3.0.0"
24372423

2438-
"@testing-library/react@^12.0.0":
2439-
version "12.1.0"
2440-
resolved "https://registry.yarnpkg.com/@testing-library/react/-/react-12.1.0.tgz#3e9a4002b0b8f986a738a2f88fc458b5af319f35"
2441-
integrity sha512-Ge3Ht3qXE82Yv9lyPpQ7ZWgzo/HgOcHu569Y4ZGWcZME38iOFiOg87qnu6hTEa8jTJVL7zYovnvD3GE2nsNIoQ==
2424+
"@testing-library/react@^16.1.0":
2425+
version "16.1.0"
2426+
resolved "https://registry.yarnpkg.com/@testing-library/react/-/react-16.1.0.tgz#aa0c61398bac82eaf89776967e97de41ac742d71"
2427+
integrity sha512-Q2ToPvg0KsVL0ohND9A3zLJWcOXXcO8IDu3fj11KhNt0UlCWyFyvnCIBkd12tidB2lkiVRG8VFqdhcqhqnAQtg==
24422428
dependencies:
24432429
"@babel/runtime" "^7.12.5"
2444-
"@testing-library/dom" "^8.0.0"
24452430

24462431
"@testing-library/[email protected]":
24472432
version "14.5.2"
@@ -2458,11 +2443,6 @@
24582443
resolved "https://registry.yarnpkg.com/@trysound/sax/-/sax-0.2.0.tgz#cccaab758af56761eb7bf37af6f03f326dd798ad"
24592444
integrity sha512-L7z9BgrNEcYyUYtF+HaEfiS5ebkh9jXqbszz7pC0hRBPaatV0XjSD3+eHrpqFemQfgwiFF0QPIarnIihIDn7OA==
24602445

2461-
"@types/aria-query@^4.2.0":
2462-
version "4.2.2"
2463-
resolved "https://registry.yarnpkg.com/@types/aria-query/-/aria-query-4.2.2.tgz#ed4e0ad92306a704f9fb132a0cfcf77486dbe2bc"
2464-
integrity sha512-HnYpAE1Y6kRyKM/XkEuiRQhTHvkzMBurTHnpFLYLBGPIylZNPs9jJcuOOYWxPLJCSEtmZT0Y8rHDokKN7rRTig==
2465-
24662446
"@types/aria-query@^5.0.1":
24672447
version "5.0.1"
24682448
resolved "https://registry.yarnpkg.com/@types/aria-query/-/aria-query-5.0.1.tgz#3286741fb8f1e1580ac28784add4c7a1d49bdfbc"
@@ -2660,6 +2640,11 @@
26602640
dependencies:
26612641
"@types/react" "*"
26622642

2643+
"@types/react-dom@^18.0.0":
2644+
version "18.3.5"
2645+
resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-18.3.5.tgz#45f9f87398c5dcea085b715c58ddcf1faf65f716"
2646+
integrity sha512-P4t6saawp+b/dFrUr2cvkVsfvPguwsxtH6dNIYRllMsefqFzkZk5UIjzyDOv5g1dXIPdG4Sp1yCR4Z6RCUsG/Q==
2647+
26632648
"@types/react-select@^3.0.26":
26642649
version "3.1.2"
26652650
resolved "https://registry.yarnpkg.com/@types/react-select/-/react-select-3.1.2.tgz#38627df4b49be9b28f800ed72b35d830369a624b"
@@ -6867,11 +6852,6 @@ lunr@^2.3.9:
68676852
resolved "https://registry.yarnpkg.com/lunr/-/lunr-2.3.9.tgz#18b123142832337dd6e964df1a5a7707b25d35e1"
68686853
integrity sha512-zTU3DaZaF3Rt9rhN3uBMGQD3dD2/vFQqnvZCDv4dl5iOzq2IZQqTxu90r4E5J+nP70J3ilqVCrbho2eWaeW8Ow==
68696854

6870-
lz-string@^1.4.4:
6871-
version "1.4.4"
6872-
resolved "https://registry.yarnpkg.com/lz-string/-/lz-string-1.4.4.tgz#c0d8eaf36059f705796e1e344811cf4c498d3a26"
6873-
integrity sha1-wNjq82BZ9wV5bh40SBHPTEmNOiY=
6874-
68756855
lz-string@^1.5.0:
68766856
version "1.5.0"
68776857
resolved "https://registry.yarnpkg.com/lz-string/-/lz-string-1.5.0.tgz#c1ab50f77887b712621201ba9fd4e3a6ed099941"

0 commit comments

Comments
 (0)