Revert "[nrf fromtree] settings_fcb: Fix storing the data"

This reverts commit 92e513f.

Signed-off-by: Martí Bolívar <[email protected]>

Author: mbolivar-nordic

subsys/settings/src/settings_fcb.c

@@ -317,16 +317,12 @@ static int settings_fcb_save_priv(struct settings_store *cs, const char *name,
 	wbs = cf->cf_fcb.f_align;
 	len = settings_line_len_calc(name, val_len);
 
-	for (i = 0; i < cf->cf_fcb.f_sector_cnt; i++) {
+	for (i = 0; i < cf->cf_fcb.f_sector_cnt - 1; i++) {
 		rc = fcb_append(&cf->cf_fcb, len, &loc.loc);
 		if (rc != -ENOSPC) {
 			break;
 		}
-
-		/* FCB can compress up to cf->cf_fcb.f_sector_cnt - 1 times. */
-		if (i < (cf->cf_fcb.f_sector_cnt - 1)) {
-			settings_fcb_compress(cf);
-		}
+		settings_fcb_compress(cf);
 	}
 	if (rc) {
 		return -EINVAL;