Revert "[nrf fromlist] storage/stream: allow NULL data pointer when len is 0"

This reverts commit d9b5c11.

Signed-off-by: Martí Bolívar <[email protected]>

Author: mbolivar-nordic

subsys/storage/stream/stream_flash.c

@@ -115,7 +115,7 @@ int stream_flash_buffered_write(struct stream_flash_ctx *ctx, const u8_t *data,
 	size_t fill_length;
 	u8_t filler;
 
-	if (ctx == NULL || (data == NULL && len != 0)) {
+	if (!ctx || !data) {
 		return -EFAULT;
 	}
 

tests/subsys/storage/stream/stream_flash/src/main.c

@@ -306,26 +306,6 @@ static void test_stream_flash_buffered_write_callback(void)
 	zassert_equal(rc, -EFAULT, "expected failure from callback");
 }
 
-static void test_stream_flash_flush(void)
-{
-	int rc;
-	int num_pages = MAX_NUM_PAGES - 1;
-
-	init_target();
-
-	rc = stream_flash_buffered_write(&ctx, write_buf,
-					 (page_size * num_pages) + 128, false);
-	zassert_equal(rc, 0, "expected success");
-
-	/* Perform flush with NULL data pointer and non-0 lentgth */
-	rc = stream_flash_buffered_write(&ctx, NULL, 4, true);
-	zassert_true(rc < 0, "expected failure");
-
-	/* Perform flush with NULL data pointer and 0 lentgth */
-	rc = stream_flash_buffered_write(&ctx, NULL, 0, true);
-	zassert_equal(rc, 0, "expected success");
-}
-
 #ifdef CONFIG_STREAM_FLASH_ERASE
 static void test_stream_flash_buffered_write_whole_page(void)
 {
@@ -401,7 +381,6 @@ void test_main(void)
 	     ztest_unit_test(test_stream_flash_buffered_write_multi_page),
 	     ztest_unit_test(test_stream_flash_buf_size_greater_than_page_size),
 	     ztest_unit_test(test_stream_flash_buffered_write_callback),
-	     ztest_unit_test(test_stream_flash_flush),
 	     ztest_unit_test(test_stream_flash_buffered_write_whole_page),
 	     ztest_unit_test(test_stream_flash_erase_page),
 	     ztest_unit_test(test_stream_flash_bytes_written)