Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: twitter/typeahead.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: inniaccounts/typeahead.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Dec 8, 2016

  1. What it's trying to do is just show that.limit rows, whether it comes as 

    one or 10 messages.
But there's a bug. you want to append 5 if the limit is 5 and 0 has been
rendered already, even if there are 10 in the list,
Adding suggestions.length to rendered before the slice, means you get no
results if returned array is 10, 0 rendered limit 5.
Simple fix is to add it afterwards.
    [email protected] authored and [email protected] committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    1f5a6f2 View commit details
    Browse the repository at this point in the history
Loading